Fix POSIX ERE in SPDX License List matching guidelines - #1449
Merged
Conversation
To address "'and is composed of 4 fields' - only 2 required" and "Example (?i:copyright.{0,200}). is not POSIX ERE" points in spdx#1419
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
added
typo
bact
changed the title
goneall
approved these changes
Jul 21, 2026
goneall
approved these changes
Jul 22, 2026
Collaborator
Author
|
Will merge this editorial fix with one approval after 10 days period. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address two points in #1419
The original and match rule fields are only required for a rule type:
<<var; . . . >>.(?i)is not a POSIX ERE expression, use[Cc]instead.Note that the new
match="[Cc]opyright.{0,200}."is not equivalent tomatch="(?i:copyright.{0,200}).", but sufficient enough to demonstrate the point that thematchfield can use a regular expression.