[3.0] Use MAJOR.MINOR version JSON-LD context URL in example - #1247
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
The example validation failed, because https://spdx.org/schema/3.0/spdx-json-schema.json is not exist yet.
|
|
The URL now appears to work - @bact - can you re-trigger the CI - perhaps by rebasing - and see if it passes? |
|
We don't yet have a clear path to republish As I understand, if we are still in 3.0.x and don't have 3.1 yet, do we have to push |
@bact - do we need to resolve the republish issue to merge this PR? If not, I just want to make sure the CI passes and I can't re-trigger it myself. |
|
I just created #1331 to force a validation. It failed with the following: @JPEWdev @bact @zvr - Do we need to update the checks? I haven't spent too much time looking into the error. |
Add something to trigger the CI. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Also print all URLs to assist debugging Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
From the run log: The content of these files have to be the updated ones with "3.0" (not "3.0.1") version in URLs or term IRIs. |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
https://spdx.org/rdf/3.0/spdx-context.jsonld still redirects to a context document with For ISO version, the base IRI is now |
|
The redirect is to the github.io page for the context which is still generating URI's with the patch version. If we push out a new context file without the patch version for the 3.0.1 branch, it will likely break many tools that are using the patch version. Do we need to do a new release 3.0.2 with the major and minor version? |
|
To keep existing tools work without the need to update anything, https://spdx.org/rdf/3.0.1/spdx-context.jsonld may keep using https://spdx.org/rdf/3.0/spdx-context.jsonld (which will be considered as the latest within 3.0 series looking forward, including 3.0.2) and any https://spdx.org/rdf/3.x/spdx-context.jsonld should use -- We may also setup URL redirections like this for all artifacts (model, context, annotation, schema): RewriteEngine On
# 1. TEMPORARY REDIRECT (302) - This will change when a new 3.X version is released
# Change "3.0" in the target to "3.1" when 3.1 is released
RewriteRule ^/?rdf/3/spdx-context\.jsonld$ https://spdx.org/rdf/3.0/spdx-context.jsonld [R=302,L]
RewriteRule ^/?rdf/3/spdx-model\.ttl$ https://spdx.org/rdf/3.0/spdx-model.ttl [R=302,L]
# 2. PERMANENT REDIRECT (301) - 3.0.Y will always map back to 3.0
# Condition: Y cannot be exactly the single character "1"
RewriteRule ^/?rdf/3\.0\.(?!1$)(.+)/spdx-context\.jsonld$ https://spdx.org/rdf/3.0/spdx-context.jsonld [R=301,L]
RewriteRule ^/?rdf/3\.0\.(?!1$)(.+)/spdx-model\.ttl$ https://spdx.org/rdf/3.0/spdx-model.ttl [R=301,L]
# 3. PERMANENT REDIRECT (301) - 3.X.Y will always map back to its respective 3.X
RewriteRule ^/?rdf/3\.([^/]+)\.(.+)/spdx-context\.jsonld$ https://spdx.org/rdf/3.$1/spdx-context.jsonld [R=301,L]
RewriteRule ^/?rdf/3\.([^/]+)\.(.+)/spdx-model\.ttl$ https://spdx.org/rdf/3.$1/spdx-model.ttl [R=301,L] |
To use "3.0" RDF URLs (version without patch version), as required by spdx/spdx-3-model#1046, we need to verify if new RDF URLs are working.
We may check that with an SBOM example (
examples/jsonld/package_sbom.json) and the example validation workflow in this repo.This issue may not directly affect the texts in the ISO publication but without the fix the texts in ISO publication may not back with relevant working URLs.