Repository navigation
Conversation
spackbot-triage
Bot
added
new-version
spackbot-triage
Bot
added
the
new-variant
Contributor
Author
|
@greenc-FNAL or @ax3l, are either of you able to review this? |
greenc-FNAL
previously approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The +threadsafe variant passes an unused CMake option for Catch2 3.10.0 and 3.11.0, leaving thread-safe assertions disabled unless the option name is selected by version.
1 open issue
What changed in this PR
Updates Spack’s Catch2 recipe with newer releases and an optional thread-safe assertions variant.
Changes:
- Adds ten release entries and checksums spanning 3.10.0–3.16.0.
- Adds a default-off
threadsafevariant for versions 3.9 onward and connects it to CMake configuration.
| File | Description |
|---|---|
repos/spack_repo/builtin/packages/catch2/package.py |
Adds Catch2 releases and the threadsafe variant with CMake option handling. |
Review effort: Balanced
| args.append(self.define_from_variant("CMAKE_POSITION_INDEPENDENT_CODE", "pic")) | ||
| args.append(self.define_from_variant("BUILD_SHARED_LIBS", "shared")) | ||
| if "+threadsafe" in spec: | ||
| args.append(self.define("CATCH_CONFIG_THREAD_SAFE_ASSERTIONS", True)) |
Member
There was a problem hiding this comment.
Interesting o.0 Feel free to make more robust or limit support for this to 3.12+ after it settled for one option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue recipe updates. This PR also adds the
threadsafevariant which enables thread-safe assertions.