Structural damage changes to weapons#44643
Open
iaada wants to merge 8 commits into
Open
Conversation
themias
added
P3: Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Damage changes for specifically structural damage on various weapons.
Don't merge until after structures have been rebalanced.
Why / Balance
Structure damage numbers have been really high. This is partly due to an arms race against damage modifier sets which have very high resistances.
It also ended up on several weapons without a real justification. Per space-wizards/docs#660 , use of structural damage has been largely reduced to entities with a thematic tie to destroying walls and stuff.
Technical details
Two increases to structural damage were given. The first is the Histrov, which was tuned to destroy basic walls again. The second was Mjollnir, because it just felt right.
Test plan
Demonstrated in spreadsheets, specifically: https://docs.google.com/spreadsheets/d/1JDhDnWAUUNR00rULj8mnZlbIfCU_b4UqqP52qNn1PH4/edit?pli=1&gid=479310353#gid=479310353
Media
Previous damage against old structures:
Previous damage against new structures:
New damage against new structures:
Requirements
Changelog
Probably not worth a cl since the changes are hard to notice in the wake of the structure rebalance.