Добавление SCP-208 "Бес"#1060
Open
666XxttimurkaxX666 wants to merge 8 commits into
Open
Conversation
Contributor
|
RSI Diff Bot; head commit 641fdad merging into 825e5c1 Resources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi
Resources/Textures/_Scp/Mobs/Scp/scp-208.rsi
|
Contributor
📝 WalkthroughWalkthroughДобавлен полный набор сущностей, конфигураций и локализаций для SCP-208: прототип моба, инвентарь, действие щита, химическая пена, одежда, шкаф снаряжения, спавнеры, ghost-role, трекер времени, теги и RSI-метаданные. ChangesSCP-208 «Bes» — полная реализация
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Prototypes/_Scp/InventoryTemplates/scp208.yml (1)
1-85:⚠️ Potential issue | 🟡 MinorДобавьте отсутствующие слоты инвентаря из стандартного шаблона или документируйте причину упрощения.
Шаблон
scp208содержит только 10 базовых слотов, тогда как стандартный шаблонhumanвключает дополнительные слоты:outerClothing,gloves,eyes,maskиsuitstorage.Если это намеренное решение для баланса SCP-208, добавьте комментарий в YAML файл. Если нет — рекомендуется добавить недостающие слоты.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/_Scp/InventoryTemplates/scp208.yml` around lines 1 - 85, The scp208 inventory template is missing several slots that exist in the standard human template: outerClothing, gloves, eyes, mask, and suitstorage. Either add these missing slot definitions to the scp208 template with appropriate configuration (slotTexture, slotFlags, uiWindowPos, etc.) to match the human template structure, or add a YAML comment at the top of the scp208 template explaining the intentional design decision to exclude these slots for game balance purposes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Resources/Locale/en-US/_prototypes/_scp/entities/mobs/player/scp/main/scp208.ftl`:
- Line 1: The entity ent-Scp208 currently has an incomplete placeholder value of
`???` instead of a proper name. Replace the `???` placeholder with an
appropriate English name for SCP-208, such as `SCP-208 "Bes"`, to ensure the
entity has a descriptive and correct display name in the localization file.
In
`@Resources/Locale/ru-RU/_prototypes/_scp/entities/mobs/player/scp/main/scp208.ftl`:
- Line 1: Replace the placeholder `???` value assigned to the `ent-Scp208` key
with the proper Russian translation. Use the reference format from the scp.ftl
file which shows "SCP-208 «Бес»" as a guide for the naming convention. The
translation should be localized and descriptive, providing either the simple
translated name or an expanded entity description in Russian, following the
project's localization requirements.
In `@Resources/Prototypes/_Scp/Actions/scp208.yml`:
- Line 4: The description field in the scp208.yml prototype contains Russian
text instead of an English fallback, which violates ss14-naming-conventions and
causes validation pipeline errors. Replace the Russian description text with an
appropriate English fallback translation, and then move the original Russian
text to the corresponding FTL localization file to maintain multilingual support
while keeping the YAML prototype compliant with naming conventions.
- Line 5: The Scp208Shield action in scp208.yml is incorrectly using the
HideSpawnMenu category. The HideSpawnMenu category is reserved exclusively for
testing and debugging prototypes, but since Scp208Shield is a legitimate
gameplay action used in the SCP-208 prototype, this category should be removed
entirely from the categories list for this action.
In `@Resources/Prototypes/_Scp/Entities/Markers/scp.yml`:
- Around line 171-185: The SpawnScp208 entity prototype has a duplicate ID that
conflicts with another prototype defined earlier in the file, which will cause a
runtime error since the YAML prototype system requires unique identifiers for
each entity definition. Change the id field in this SCP-208 spawner entity to a
unique identifier that distinguishes it from the existing SpawnScp208 prototype,
while maintaining a clear naming convention that reflects its purpose as a 50%
spawn rate variant.
---
Outside diff comments:
In `@Resources/Prototypes/_Scp/InventoryTemplates/scp208.yml`:
- Around line 1-85: The scp208 inventory template is missing several slots that
exist in the standard human template: outerClothing, gloves, eyes, mask, and
suitstorage. Either add these missing slot definitions to the scp208 template
with appropriate configuration (slotTexture, slotFlags, uiWindowPos, etc.) to
match the human template structure, or add a YAML comment at the top of the
scp208 template explaining the intentional design decision to exclude these
slots for game balance purposes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7cd62790-42dd-430c-8d9d-94b9c64f8948
⛔ Files ignored due to path filters (5)
Resources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Scp/Mobs/Scp/scp-208.rsi/scp-208.pngis excluded by!**/*.png
📒 Files selected for processing (25)
Resources/Locale/en-US/_prototypes/_scp/actions/scp208.ftlResources/Locale/en-US/_prototypes/_scp/catalog/fills/lockers/dressers.ftlResources/Locale/en-US/_prototypes/_scp/entities/clothing/uniforms/scp208.ftlResources/Locale/en-US/_prototypes/_scp/entities/mobs/player/scp/main/scp208.ftlResources/Locale/en-US/_strings/_scp/roles/scp.ftlResources/Locale/en-US/_strings/_scp/scp/scp208.ftlResources/Locale/ru-RU/_prototypes/_scp/actions/scp208.ftlResources/Locale/ru-RU/_prototypes/_scp/catalog/fills/lockers/dressers.ftlResources/Locale/ru-RU/_prototypes/_scp/entities/clothing/uniforms/scp208.ftlResources/Locale/ru-RU/_prototypes/_scp/entities/mobs/player/scp/main/scp208.ftlResources/Locale/ru-RU/_strings/_scp/roles/scp.ftlResources/Locale/ru-RU/_strings/_scp/scp/scp208.ftlResources/Prototypes/_Scp/Actions/scp208.ymlResources/Prototypes/_Scp/Catalog/Fills/Lockers/dressers.ymlResources/Prototypes/_Scp/Entities/Clothing/Uniforms/scp208.ymlResources/Prototypes/_Scp/Entities/Effects/chemistry_effects.ymlResources/Prototypes/_Scp/Entities/Markers/scp.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp173.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp208.ymlResources/Prototypes/_Scp/InventoryTemplates/scp208.ymlResources/Prototypes/_Scp/Roles/Jobs/SCP/ghostrole.ymlResources/Prototypes/_Scp/Roles/play_time_trackers.ymlResources/Prototypes/_Scp/tags.ymlResources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/meta.jsonResources/Textures/_Scp/Mobs/Scp/scp-208.rsi/meta.json
Contributor
|
Этот PR содержит конфликты, пожалуйста, разрешите их, прежде чем мы сможем его оценить. |
Contributor
Author
|
да долбаные тегиииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииииии |
Contributor
|
Вот этот увы нет, его же пепер рисовал? |
Contributor
Author
не |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/meta.json`:
- Line 4: The attribution in scp208-uniform.rsi’s metadata appears to credit
peper incorrectly. Update the copyright entry in the meta.json for
scp208-uniform.rsi by either removing peper if they did not author this asset,
or moving that credit to the correct related asset if it belongs elsewhere. Use
the existing metadata field in meta.json and keep the remaining attribution
aligned with the actual authors of this uniform.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 556ffced-9960-49e6-9c9b-d7517d5c701e
⛔ Files ignored due to path filters (2)
Resources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Scp/Mobs/Scp/scp-208.rsi/scp-208.pngis excluded by!**/*.png
📒 Files selected for processing (6)
Resources/Prototypes/_Scp/Actions/scp208.ymlResources/Prototypes/_Scp/Entities/Markers/scp.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp208.ymlResources/Prototypes/_Scp/tags.ymlResources/Textures/_Scp/Clothing/Uniforms/scp208-uniform.rsi/meta.jsonResources/Textures/_Scp/Mobs/Scp/scp-208.rsi/meta.json
💤 Files with no reviewable changes (1)
- Resources/Prototypes/_Scp/Entities/Markers/scp.yml
Contributor
Author
|
@WardexOfficial все спрайты на всех прах были заменены и приняты мордастом |
Contributor
|
Этот PR содержит конфликты, пожалуйста, разрешите их, прежде чем мы сможем его оценить. |
Contributor
Author
пофикшено лох |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Краткое описание | Short description
это типо разумный добрый сцп который пиздец какой мирный и любит помогать людям
может появится в комплексе с 50% шансом
Ссылка на багрепорт/Предложение | Related Issue/Bug Report
Медиа (Видео/Скриншоты) | Media (Video/Screenshots)
Changelog
🆑 timur
Summary by CodeRabbit
Summary by CodeRabbit