Skip to content

fix: warning in CI for dist-typecheck workflow#2177

Merged
birkskyum merged 5 commits into
solidjs:mainfrom
hirehamir:fix/warning-in-ci-for-dist-typecheck
Jul 16, 2026
Merged

fix: warning in CI for dist-typecheck workflow#2177
birkskyum merged 5 commits into
solidjs:mainfrom
hirehamir:fix/warning-in-ci-for-dist-typecheck

Conversation

@hirehamir

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

The dist-typecheck workflow has a Node.js 20 is deprecated. warning.

What is the new behavior?

We use the latest versions of actions to remove all warnings from that workflow.

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f843731

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit f843731
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a58dd8e6809980008c31e59
😎 Deploy Preview https://deploy-preview-2177--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread .github/workflows/dist-typecheck.yml
@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2177
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2177

commit: f843731

@birkskyum
birkskyum merged commit 52219c1 into solidjs:main Jul 16, 2026
10 checks passed
@hirehamir
hirehamir deleted the fix/warning-in-ci-for-dist-typecheck branch July 16, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dist-typecheck workflow has a Node.js 20 is deprecated. warning

3 participants