vite preview polish#2105
Merged
birkskyum merged 4 commits intoJul 16, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6546b8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
themavik
reviewed
Mar 19, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Code review
Scoping content-encoding: identity to HTML responses only makes sense — the previous behavior disabled compression for all preview responses. Now only SSR HTML gets identity; other content types (JSON, assets, etc.) can be compressed. The content-type?.startsWith('text/html') check handles null safely. LGTM.
brenelz
approved these changes
Mar 28, 2026
birkskyum
force-pushed
the
better-way-to-disable-compression
branch
from
July 16, 2026 20:41
01c671d to
6546b8a
Compare
birkskyum
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes an edge case with mp4
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information