Skip to content

fix(ios): typing attributes clearing on keystrokes #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejsztynx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ios): typing attributes clearing on keystrokes #773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32b65ea
fix: typing attributes sometimes clearing on keystrokes
hejsztynx Aug 13, 2026
873dca6
fix: grammar
hejsztynx Aug 14, 2026
0b3ca69
fix: lint
hejsztynx Aug 14, 2026
2b113b1
Merge branch 'main' into @ksienkiewicz/fix-ios-typing-attributes-desync
hejsztynx Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ios/EnrichedTextInputView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2000,6 +2000,14 @@ - (bool)textView:(UITextView *)textView
return NO;
}

// to be sure, we re-run typingAttributes management right before the
// character actually lands. Some times between selection change and the next
// keystroke typing attributes might get removed - seems like a native TextKit
// issue
Comment thread
Copilot marked this conversation as resolved.
Outdated
if (range.length == 0 && text.length > 0) {
Comment thread
hejsztynx marked this conversation as resolved.
Outdated
[attributesManager repeatRecentTypingAttributesManagement];
}

return YES;
}

Expand Down
1 change: 1 addition & 0 deletions ios/inputAttributesManager/InputAttributesManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- (void)didRemoveTypingAttribute:(NSString *)key;
- (void)clearRemovedTypingAttributes;
- (void)manageTypingAttributesWithOnlySelection:(BOOL)onlySelectionChanged;
- (void)repeatRecentTypingAttributesManagement;
- (void)handleDirtyRangesStyling;
- (NSSet<NSString *> *)customAttributesKeys;
@end
8 changes: 8 additions & 0 deletions ios/inputAttributesManager/InputAttributesManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ @implementation InputAttributesManager {
NSMutableArray<NSValue *> *_dirtyRanges;
NSSet *_customAttributesKeys;
NSMutableSet *_removedTypingAttributes;
BOOL _recentManagedTypingAttributesOnlySelection;
}

- (instancetype)initWithInput:(EnrichedTextInputView *)input {
self = [super init];
_input = input;
_dirtyRanges = [[NSMutableArray alloc] init];
_removedTypingAttributes = [[NSMutableSet alloc] init];
_recentManagedTypingAttributesOnlySelection = NO;

// setup customAttributes
NSMutableSet *_customAttrsSet = [[NSMutableSet alloc] init];
Expand Down Expand Up @@ -129,6 +131,7 @@ - (void)handleDirtyRangesStyling {
}

- (void)manageTypingAttributesWithOnlySelection:(BOOL)onlySelectionChanged {
_recentManagedTypingAttributesOnlySelection = onlySelectionChanged;
EnrichedInputTextView *textView = _input->textView;
NSRange selectedRange = textView.selectedRange;

Expand Down Expand Up @@ -219,4 +222,9 @@ - (void)manageTypingAttributesWithOnlySelection:(BOOL)onlySelectionChanged {
textView.typingAttributes = newAttrs;
}

- (void)repeatRecentTypingAttributesManagement {
[self manageTypingAttributesWithOnlySelection:
_recentManagedTypingAttributesOnlySelection];
}

@end
Loading