-
Notifications
You must be signed in to change notification settings - Fork 64
feat: add deletion by ref #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1296,6 +1296,8 @@ - (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args { | |
| if (!_placeholderLabel.isHidden) { | ||
| [self refreshPlaceholderLabelStyles]; | ||
| } | ||
| } else if ([commandName isEqualToString:@"deleteAtSelection"]) { | ||
| [self deleteAtSelection]; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -1335,6 +1337,18 @@ - (void)setValue:(NSString *)value { | |
| [self anyTextMayHaveBeenModified]; | ||
| } | ||
|
|
||
| - (void)deleteAtSelection { | ||
| UITextRange *selectedRange = self.textView.selectedTextRange; | ||
|
|
||
| if (selectedRange.empty) { | ||
| [self.textView deleteBackward]; | ||
| } else { | ||
| [self.textView replaceRange:selectedRange withText:@""]; | ||
| } | ||
|
|
||
| [self anyTextMayHaveBeenModified]; | ||
| } | ||
|
Comment on lines
+1340
to
+1359
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it okay if I use selectedTextRange instead of selectedRange?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. It's just that everywhere around the code a
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. O ok, yes it would be better to use |
||
|
|
||
| - (void)setCustomSelection:(NSInteger)visibleStart end:(NSInteger)visibleEnd { | ||
| NSString *text = textView.textStorage.string; | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.