Skip to content

fix: Don't treat strings as resolvable#2703

Draft
iwoplaza wants to merge 1 commit into
mainfrom
fix/dont-treat-strings-as-resolvable
Draft

fix: Don't treat strings as resolvable#2703
iwoplaza wants to merge 1 commit into
mainfrom
fix/dont-treat-strings-as-resolvable

Conversation

@iwoplaza

@iwoplaza iwoplaza commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@iwoplaza iwoplaza force-pushed the fix/dont-treat-strings-as-resolvable branch from a9cf7e1 to b78d332 Compare July 9, 2026 12:49
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@9b1e51f7036aac121d20fc24c097a001e11b080a
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/cli@9b1e51f7036aac121d20fc24c097a001e11b080a
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@9b1e51f7036aac121d20fc24c097a001e11b080a
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/react@9b1e51f7036aac121d20fc24c097a001e11b080a
https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@9b1e51f7036aac121d20fc24c097a001e11b080a

benchmark
view benchmark

commit
view commit

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.81, 1.65, 3.65, 5.65, 6.09, 10.12, 19.78, 22.46]
  line [0.89, 1.85, 4.18, 5.79, 6.70, 9.73, 19.52, 21.52]
  line [0.81, 1.63, 3.70, 5.22, 6.57, 11.48, 19.23, 22.52]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.25, 0.45, 0.62, 0.78, 1.00, 1.10, 1.30, 1.42]
  line [0.26, 0.46, 0.66, 0.91, 1.05, 1.13, 1.34, 1.47]
  line [0.33, 0.52, 0.65, 0.76, 0.96, 1.04, 1.29, 1.42]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.86, 1.97, 4.09, 5.62, 10.57, 22.55, 49.05, 98.26]
  line [0.86, 1.94, 3.90, 5.60, 10.98, 23.32, 48.91, 100.72]
  line [0.87, 1.71, 3.63, 5.51, 10.98, 22.73, 51.17, 98.36]
Loading

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased (max -0.20%) ➖ Unchanged 🔴 Increased (max 0.06%) ❔ Unknown
262 36 23 0

import { ... } in PR vs import * as ... in PR (is the library tree-Shakeable?):

Test tsdown
tgpu_init.ts 256.62 kB ($${\color{green}-3.2\%}$$)
tgpu_initFromDevice.ts 256.10 kB ($${\color{green}-3.4\%}$$)
tgpu_resolve.ts 187.33 kB ($${\color{green}-29.3\%}$$)
tgpu_resolveWithContext.ts 187.27 kB ($${\color{green}-29.3\%}$$)
tgpu_bindGroupLayout.ts 68.97 kB ($${\color{green}-74.0\%}$$)
tgpu_mutableAccessor.ts 65.90 kB ($${\color{green}-75.1\%}$$)
tgpu_accessor.ts 65.88 kB ($${\color{green}-75.1\%}$$)
tgpu_privateVar.ts 65.26 kB ($${\color{green}-75.4\%}$$)
tgpu_workgroupVar.ts 65.26 kB ($${\color{green}-75.4\%}$$)
tgpu_const.ts 64.49 kB ($${\color{green}-75.7\%}$$)
tgpu_fn.ts 37.96 kB ($${\color{green}-85.7\%}$$)
tgpu_fragmentFn.ts 37.89 kB ($${\color{green}-85.7\%}$$)
tgpu_vertexFn.ts 37.70 kB ($${\color{green}-85.8\%}$$)
tgpu_computeFn.ts 37.41 kB ($${\color{green}-85.9\%}$$)
tgpu_vertexLayout.ts 26.60 kB ($${\color{green}-90.0\%}$$)
tgpu_comptime.ts 14.40 kB ($${\color{green}-94.6\%}$$)
tgpu_unroll.ts 2.59 kB ($${\color{green}-99.0\%}$$)
tgpu_slot.ts 1.57 kB ($${\color{green}-99.4\%}$$)
tgpu_lazy.ts 1.22 kB ($${\color{green}-99.5\%}$$)

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

@iwoplaza iwoplaza force-pushed the fix/dont-treat-strings-as-resolvable branch from b78d332 to 06c0e25 Compare July 9, 2026 13:00
@iwoplaza iwoplaza force-pushed the fix/dont-treat-strings-as-resolvable branch from 06c0e25 to 9b1e51f Compare July 9, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant