Skip to content

chore(language-server): integrate LS#6969

Open
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#6969
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls

Conversation

@team-ide-user

@team-ide-user team-ide-user commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Changes since last integration of Language Server

commit 5bbf698d7cffbd98074624a8846071524457bee5
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Mon Jul 6 18:30:00 2026 +0200

    fix: stabilize OAuth storage bridge last-write-wins under rapid token rotation [IDE-2104] (#1352)
    
    Test_RegisterOAuthStorageBridge_SerializesRapidTokenRotations flaked on
    Windows CI: after three rapid token rotations the stored token was the
    first instead of the last.
    
    Root cause: when credentialUpdateWorker writes a token via conf.Set, the
    persisted OAuth key re-fires the storage-bridge callback, which calls
    QueueCredentialUpdate again and re-enqueues the same token behind newer
    ones. On Windows (15ms clock resolution) all rotation tokens share an
    expiry, so shouldUpdateToken lets the stale re-enqueued copy overwrite
    the final token.
    
    Fix: add an atomic.Pointer[string] guard (writingToken). The worker marks
    the token it is applying (cleared via defer so a panic cannot leave it
    armed) and QueueCredentialUpdate skips the re-entrant enqueue of that same
    token. Add a deterministic regression test using require.Never that is RED
    without the guard and GREEN with it across GOMAXPROCS 1/2/4.
    
    Produced by an automated flake-fix loop.

M	infrastructure/authentication/auth_configuration_test.go
M	infrastructure/authentication/auth_service_impl.go

commit 3a96c5d669f75601c8a27896e2cee46a691a54e5
Author: nick-y-snyk <nikita.yasnohorodskyi@snyk.io>
Date:   Thu Jul 2 16:03:05 2026 +0200

    fix: use configured CLI release channel instead of runtime version [IDE-2133] (#1367)
    
    HTML settings page and CLI download logic both derived the release
    channel from the running binary's version instead of reading the
    user-configured cli_release_channel setting, so changes silently
    reverted after restart. Also makes the download path handle a pinned
    CLI version (not just named channels) by building the URL directly
    instead of running it through the channel-keyed protocol-lookup.

M	infrastructure/cli/install/releases.go
M	infrastructure/cli/install/releases_test.go
M	infrastructure/configuration/config_html.go
M	infrastructure/configuration/config_html_test.go

@team-ide-user team-ide-user requested a review from a team as a code owner July 6, 2026 16:35
@team-ide-user team-ide-user enabled auto-merge July 6, 2026 16:35
@snyk-io

snyk-io Bot commented Jul 6, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

"chore: automatic integration of language server 5bbf698d7cffbd98074624a8846071524457bee5" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 4d9c121

@snyk-pr-review-bot

This comment has been minimized.

@team-ide-user team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch from c8fc9f0 to 4d9c121 Compare July 7, 2026 14:03
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants