feat: ConfigureTokenPool changeset (EVM v2.0)#2195
Open
futureproof1 wants to merge 7 commits into
Open
Conversation
|
👋 futureproof1, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
ConfigureTokenPoolchangeset (deployment/tokens/configure_token_pool.go): a family-agnostic changeset that applies small, targeted, idempotent configuration changes to existing EVM v2.0.0+ token pools:finalityConfigrateLimitAdmin/feeAdmintokenTransferFeeConfig(partial)rateLimits(per-finality-bucket)Every field below
tokenPoolRefis optional: absent = leave on-chain state untouched; explicit values (zero address, disabled-with-zeros) clear things. Every write is read-compare-write — matching on-chain state emits zero transactions (no wasted gas, no MCMS predecessor conflicts). Output is assembled via the sharedOutputBuilder, so MCMS-owned pools produce timelock proposals and EOA-owned pools execute directly.To fill the one capability gap, this adds an optional adapter interface
TokenPoolAdminAdapter(+SetTokenPoolAdminsSequenceInput) and a new EVM v2 sequenceSetTokenPoolAdmins, wired on the v2TokenAdapter.PR breakdown
This is PR#1 of 3:
Verify rejects resolved pool versions
< 2.0.0with a clear, scoped error.Deliberate divergences from sibling changesets
SetTokenPoolRateLimits, each entry configures one pool's local view of a lane and never requires a counterpart section. Bidirectional use is supported (you may configure both sides in one changeset) but never required, and no symmetry is enforced — this is the changeset's core differentiator. Rate-limit validation is structural only (max 2 buckets, one per fastFinality flag, rate ≤ capacity, disabled ⇒ zeros); inbound still gets the +10% bump, identical to existing tooling.PartialTokenTransferFeeConfig.MergeWithover the on-chain config) never resets unrelated fields — intentionally different from the token-expansion flow, which merges with chain-agnostic defaults.Testing
integration-tests/deployment/configure_token_pool_test.go:Full local verification green:
go build+go vetacross thedeployment,chains/evm, andintegration-testsmodules;chains/evmv2_0_0 suites; and the fullintegration-tests/deploymentpackage (48 pass, 0 fail). Nocore refneeded — the change is additive and Chainlink core compiles against it.Ticket
[TOOLING]: add changeset to update token pool configs
Reference: #1931