Skip to content

Evaluate using Popen(shell=False, ...) #250

Open
Open
Evaluate using Popen(shell=False, ...)#250
Labels
good first issuea relatively simple task to familiarize oneself with the code base, and the contribution processhelp wantedWe'd like help with this issue, and are happy to provide guidance

Description

@smarr
smarr
opened on Aug 20, 2024

Should we avoid using the shell for running commands?

Think this is a major change at the core of ReBench.
So, we'd probably need to carefully test this.
See #248 (comment)

Activity

  1. smarr
    added
    help wantedWe'd like help with this issue, and are happy to provide guidance
    on Aug 20, 2024

  2. smarr commented on Aug 20, 2024

    @smarr
    smarr
    on Aug 20, 2024
    OwnerAuthor

    At the moment, we request explicitly the use of a shell here:
    https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L532

    However, we run build commands without shell here:
    https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L397

  3. smarr
    added
    good first issuea relatively simple task to familiarize oneself with the code base, and the contribution process
    on Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuea relatively simple task to familiarize oneself with the code base, and the contribution processhelp wantedWe'd like help with this issue, and are happy to provide guidance

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions