[ENH] EmpiricalFitter distribution fitter - #1095
Open
utsab345 wants to merge 7 commits into
Open
Conversation
Adds EmpiricalFitter which converts the full sample into an Empirical distribution. For the univariate case (empirical per variable), it simply wraps the data in an Empirical distribution. Useful as a base component for naive distribution fitting in ensemble or reduction strategies.
fkiraly
changed the title
EmpiricalFitter distribution fitter
fkiraly
added
enhancement
module:distributions&simulation
fkiraly
requested changes
Jul 2, 2026
fkiraly
left a comment
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
I think this is not correct, since the result should be an 0D distribution, but it is a 2D distribution.
Collaborator
|
please ensure to fix code quality failures too. Please look at the developer guide. |
…tion Previously, multi-column data was reshaped into a 2D Empirical distribution via MultiIndex, which violated the contract that proba() must return a scalar (0D) distribution. Now all values are raveled into a single-column DataFrame, producing a scalar distribution regardless of input shape.
Contributor
Author
|
Fixed as per your review: |
5 tasks
patelchaitany
suggested changes
Jul 10, 2026
| """ | ||
|
|
||
| _tags = { | ||
| "authors": ["fkiraly"], |
Member
There was a problem hiding this comment.
I think you are the author for this class
| } | ||
|
|
||
| def __init__(self, time_indep=True): | ||
| self.time_indep = time_indep |
Member
There was a problem hiding this comment.
There is no need for this as we are flattening the data so this time_indep is going to make no difference as there is going to be an single row
Contributor
Author
|
Addressed review feedback:
|
patelchaitany
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1087.
Adds
EmpiricalFitterwhich converts the full sample into anEmpiricaldistribution. For the univariate case (empirical per variable), it simply wraps the data in anEmpiricaldistribution.Supports single-column and multi-column data, with a
time_indepparameter passed through toEmpirical.Useful as a base component for naive distribution fitting in ensemble or reduction strategies.