ENH: Fork cyclic_boosting into skpro and update NumPy compatibility (Fixes #1090) - #1092
Open
utsab345 wants to merge 2 commits into
Open
ENH: Fork cyclic_boosting into skpro and update NumPy compatibility (Fixes #1090)#1092utsab345 wants to merge 2 commits into
utsab345 wants to merge 2 commits into
Conversation
- Fork cyclic_boosting 1.4.0 source from upstream into skpro/libs/ - Replace deprecated np.product with np.prod (removed in numpy 2.0+) - Remove six dependency and __future__ imports (Python 3.10+ only) - Replace @six.add_metaclass with metaclass=abc.ABCMeta - Update internal imports to reference skpro.libs.cyclic_boosting - Update CyclicBoosting wrapper to import from local fork - Fix scipy minimize return: res.x[0] -> float(res.x[0]) - Fix test error message regex to match forked code format - Update python_dependencies tag to list direct deps only
fkiraly
requested changes
Jul 2, 2026
fkiraly
left a comment
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
It would be appreciated if you could run pre-commit across the files to fix the issues.
Adds exclude patterns for skpro/libs/ in: - .pre-commit-config.yaml pydocstyle hook - setup.cfg flake8 config The vendored cyclic_boosting library is kept as close to upstream as possible, so linting checks are skipped for that directory. Also runs pre-commit across all changed files, applying black/isort formatting to both vendored and skpro integration code.
Contributor
Author
|
Ran pre-commit across all 38 changed files. All hooks now pass:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1090.
This PR vendors the
cyclic_boostinglibrary intoskpro.libsand updates it for compatibility with recent NumPy versions. Since the upstream project appears to be unmaintained, this allowsskproto maintain compatibility independently while preserving the existing functionality.Changes
cyclic_boostingpackage intoskpro.libs.np.productwhere applicable).Why
The upstream
cyclic_boostingproject appears to be inactive and is no longer compatible with newer NumPy versions due to deprecated API usage. Vendoring the library intoskproenables continued maintenance, avoids dependency on an unmaintained package, and ensures compatibility with supported NumPy versions.Testing