-
Notifications
You must be signed in to change notification settings - Fork 53
[ENH] experimental get_tag hybrid method callable on class and instance
#560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fkiraly
wants to merge
6
commits into
main
Choose a base branch
from
get_tag-hybridmethod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a9aafb4
get_tag hybridmethod
fkiraly d53ac53
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7f709a4
Update _hybridmethod.py
fkiraly 651798e
Update test_hybridmethod.py
fkiraly 773c9ee
Merge branch 'get_tag-hybridmethod' of https://github.com/sktime/skba…
fkiraly 954d2c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| """Decorator for methods that can be called both on the class and on instances.""" | ||
|
|
||
|
|
||
| class hybridmethod: | ||
| """Decorator for methods that can be called both on the class and on instances. | ||
|
|
||
| The decorated method will receive the class as the first argument when called | ||
| on the class, and the instance when called on an instance. | ||
| """ | ||
|
|
||
| def __init__(self, func): | ||
| self.func = func | ||
|
|
||
| def __get__(self, obj, cls): | ||
| def wrapper(*args, **kwargs): | ||
| return self.func(obj if obj is not None else cls, *args, **kwargs) | ||
|
|
||
| return wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Tests for hybridmethod decorator.""" | ||
|
|
||
| from inspect import isclass | ||
|
|
||
| from skbase.utils._hybridmethod import hybridmethod | ||
|
|
||
|
|
||
| class HybridmethodTestclass: | ||
|
|
||
| def __init__(self): | ||
| self.ref_to_self = self | ||
|
|
||
| @hybridmethod | ||
| def method(self_or_cls): | ||
|
|
||
| if isclass(self_or_cls): | ||
| assert self_or_cls is self_or_cls.ref_to_self | ||
| else: | ||
| assert self_or_cls is self_or_cls.ref_to_self | ||
| assert isinstance(self_or_cls, self_or_cls.__class__) | ||
|
|
||
|
|
||
| HybridmethodTestclass.ref_to_self = HybridmethodTestclass | ||
|
|
||
|
|
||
| def test_hybridmethod(): | ||
| """Test that hybridmethod works as expected.""" | ||
| HybridmethodTestclass.method() | ||
| HybridmethodTestclass().method() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.