[ENH] Move MultiEmbedding to layers/_embeddings - #2391
Open
richardmilles wants to merge 1 commit into
Open
Conversation
Relocate the shared embedding module out of models/nn and keep a backward-compatible re-export so existing imports continue to work.
richardmilles
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
August 21, 2026 12:33
phoeenniixx
requested changes
Aug 22, 2026
phoeenniixx
left a comment
phoeenniixx
left a comment
Member
There was a problem hiding this comment.
Thanks!
Can you please make sure the code-quality is passing?
We use pre-commit. See the coding- standards here: https://www.sktime.net/docs/developer-guide/coding-standards/
Muhammad-Rebaal
suggested changes
Aug 26, 2026
Member
There was a problem hiding this comment.
Hi @richardmilles,
The idea is to move this file from this dir to _embeddings completely so having this file up here is useless and ensure imports correctly where it is used.
| @@ -1,219 +1,11 @@ | |||
| from typing import Optional, Union | |||
| """Backward-compatible re-export of embedding layers. | |||
Member
There was a problem hiding this comment.
This file should be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #2388.
What does this implement/fix? Explain your changes.
Moves
MultiEmbedding/TimeDistributedEmbeddingBagintolayers/_embeddingsand leaves a thin re-export inmodels.nn.embeddingsso existing imports keep working.Did you add any tests for the change?
No — existing
test_embeddingscovers the public import path.PR checklist