[ENH] Implement NBeatsKAN in v2 interface - #2383
Conversation
a24e2cb to
7c371c0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
=======================================
Coverage ? 88.29%
=======================================
Files ? 201
Lines ? 11262
Branches ? 0
=======================================
Hits ? 9944
Misses ? 1318
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7c371c0 to
8080be5
Compare
phoeenniixx
left a comment
There was a problem hiding this comment.
Nice!
Can you also look at #2373, maybe we can use the adapter here to make things easier. You can stack this PR on #2373.
FYI @Faakhir30
8080be5 to
222995c
Compare
|
@Dev10-sys for stacking upon adapter being contributed in #2373 , you can do:
And, then use that adapter instead of |
751b9ea to
42d4e5e
Compare
47d5b17 to
6ce3652
Compare
Implemented NBeatsKAN_v2 inheriting from NBeatsAdapterV2 with Kolmogorov-Arnold Network (KAN) spline layers. Added NBeatsKAN_pkg_v2 package container inheriting from Base_pkg with multi-fixture test configurations integrated into the unified estimator test suite.
6ce3652 to
517e18c
Compare
|
@phoeenniixx @Faakhir30 I have made the requested changes. Please review. |
Reference Issues/PRs
Partially addresses #1736 and #1992.
What does this implement/fix? Explain your changes.
Adds a v2 implementation of
NBeatsKANasNBeatsKAN_v2.NBeatsKAN_v2inheriting fromBaseModelwith Kolmogorov-Arnold Network (KAN) spline layers (Generic,Seasonal, andTrendblocks).NBeatsKAN_pkg_v2inheriting fromBase_pkg.tests/test_models/test_nbeatskan_v2.py.What should a reviewer concentrate their feedback on?
NBEATSGenericBlockKAN,NBEATSSeasonalBlockKAN,NBEATSTrendBlockKAN) with DataModule metadata inputsNBeatsKAN_pkg_v2Did you add any tests for the change?
tests/test_models/test_nbeatskan_v2.pywithcheck_estimatorcompliance.PR checklist
tests/test_models/test_nbeatskan_v2.py)