[ENH] Implement RecurrentNetwork (RNN) in v2 interface - #2381
Open
Dev10-sys wants to merge 2 commits into
Open
Conversation
Dev10-sys
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
August 16, 2026 11:07
Dev10-sys
force-pushed
the
feature/rnn-v2
branch
from
August 16, 2026 11:12
def5384 to
01929e4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
=======================================
Coverage ? 88.16%
=======================================
Files ? 198
Lines ? 11132
Branches ? 0
=======================================
Hits ? 9814
Misses ? 1318
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dev10-sys
force-pushed
the
feature/rnn-v2
branch
from
August 20, 2026 21:51
01929e4 to
f383f32
Compare
Dev10-sys
force-pushed
the
feature/rnn-v2
branch
from
August 21, 2026 16:54
f383f32 to
a0274aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #1736 and #1992.
What does this implement/fix? Explain your changes.
Adds a v2 implementation of
RecurrentNetwork(RNN/LSTM/GRU) asRecurrentNetwork_v2.RecurrentNetwork_v2inheriting fromBaseModelsupporting LSTM and GRU cell types.target_past,encoder_cont) derived directly from DataModule metadata.RecurrentNetwork_pkg_v2inheriting fromBase_pkgwith estimator tags and parameter fixtures.tests/test_models/test_rnn_v2.py.What should a reviewer concentrate their feedback on?
RecurrentNetwork_v2._build_input_tensorRecurrentNetwork_pkg_v2Did you add any tests for the change?
tests/test_models/test_rnn_v2.pywithcheck_estimatorcompliance and forward pass tests.PR checklist
tests/test_models/test_rnn_v2.py)