Board management tools

[kskarmoutsos]

MCP tools for managing Maniphest workboards. Pairs with skroutz-internal/phabricator#15 — the Conduit half. Neither does anything without the other.

• pha_task_edit_comment — wraps maniphest.comment.edit.
• pha_workboard_edit_column and pha_workboard_search_columns — create, rename, hide and reorder columns; surface is_hidden and proxy_phid, and page past 100 so one call can enumerate a board of 177 columns.
• pha_task_update — adds points, column_phid and comment. Transaction building moved into _build_task_transactions, shared with the bulk path.
• pha_task_bulk_update — batched edits, dry_run defaults to true.
• pha_task_aggregate — server-side counts grouped by column, priority, owner, points or staleness, so a board can be measured without pulling every task.
• pha_task_search_advanced — fields projection to trim the payload.
• pha_dashboard_edit_panel — wraps the existing dashboard.panel.edit.

Rebased onto current main: the pagination work this branch carried is already in via 8d87fd1, and due_date from e651020 is folded into the shared transaction builder. 229 unit tests pass.

Breaking: ProjectClient.create_column, delete_column, update_column_name and update_column_limit are removed, and edit_column now takes flat parameters (column_phid, project_phid, name, hidden, limit, sequence). The removed methods called endpoints that exist on no server.

[gpapakyriakopoulos]

Thanks for the board-management work. I reviewed the current head (bd3b972) and am requesting changes for the following regressions before merge:

1. Fix the new task column transaction shape. _build_task_transactions() sends {"type": "column", "value": column_phid}, while the existing ManiphestClient.create_column_transaction() uses a list of column PHIDs, as its API contract and workboard test specify. Both pha_task_update and pha_task_bulk_update use the new builder, so column moves are likely to fail on Phorge. Please reuse the existing helper or list shape and correct the new stub test that currently expects a string.
2. Make bulk dry-run previews complete. The apply path includes project membership, column, and comment transactions, but would_change only compares priority, status, owner, and points. For example, a project-only dry run returns an empty preview even though the apply call writes the change. Show every requested write in the preview, including operations whose current value is unavailable.
3. Deduplicate bulk targets by task PHID before applying. Supplying the same task as T1 and its PHID makes two edit_task calls, which can post a comment twice. Numeric aliases such as T1 and 1 can also produce a false task not found result. Normalize identifiers and edit each resolved task once.
4. Preserve or version the column-search response contract. pha_workboard_search_columns changes columns from the previous result object (data and cursor/pagination metadata) to a list. It also returns has_more without an after input or a continuation cursor. Please keep existing callers working and provide a way to fetch the next page.

Please also put a hard server-side ceiling on pha_task_aggregate.max_tasks and its page/work budget. A targeted run of the registered handler made 100 API requests and retained 10,000 tasks when the caller supplied max_tasks=10000; a shared deployment with a large task set can consume substantial API and server resources. The hidden-column search loop likewise needs a total scan budget: with include_hidden=False, a targeted run made 51 page requests to return one visible column at limit=1.

The focused tests, Ruff, and compileall pass, but the added tests use stubs/mocks and do not verify these upstream API contracts. Please add regression tests for the preview, alias deduplication, and pagination behavior, plus a live Phorge integration check for column moves and column edits. I could not run live integration tests because no Phorge test container was running.

One additional compatibility check: ProjectClient removes several public column helper methods and changes the edit_column signature. If external Python callers are supported, keep wrappers or document the breaking API change.

[kskarmoutsos]

Thanks. Addressed in fixups 9396584..a69effd.

1. Column shape: the string form is valid. Upstream documents "PHID-PCOL-1111" as the simplest value, and ManiphestTransactionEditor::buildMoveTransaction() wraps any non-array value. I switched to the list shape anyway, to match create_column_transaction() (9396584).
2. Dry-run preview: would_change now lists projects_add/remove/set, column_phid and comment for every task, with from: null because their current values aren't read (69d331f).
3. Dedup: identifiers are resolved to tasks first, and each PHID is edited once. T1, 1 and the PHID no longer collide or produce a false task not found (69d331f).
4. Column search contract: columns is the result object again (data, cursor, pagination), and there is an after input to continue from (e036f8f).

Budgets: max_tasks is capped at 5000 (at most 50 requests) and rejected above that. Column search reads at most 10 pages per call and returns the cursor when it stops. limit is capped at 1000 (e036f8f).

Tests: unit regressions cover the preview, alias dedup, cursor, scan budget and ceiling. test_edit_column_and_move_a_task_into_it runs live: it creates a column with project.column.edit, moves a task into it with _build_task_transactions, then hides and reorders it (a69effd). It skips when the server has no project.column.edit. I ran it against a Phorge container with the fork method ported in. Full suite: 507 passed, 3 failed. The same 3 fail at bd3b972 (test_workboard_complete_workflow, test_column_search_functionality, test_require_token_raises_without_token_or_client_id).

ProjectClient: no wrappers. create_column/delete_column called project.column.create/.delete, which don't exist on Phabricator, Phorge or our fork. The old edit_column(column_phid, transactions) targeted a project.column.edit that didn't exist before skroutz-internal/phabricator#15. So there's no working caller to break. I noted the removal in the PR description.

[gpapakyriakopoulos]

Thanks for addressing the review feedback and adding regression coverage. I verified the fixes for task aggregation limits, column transactions, bulk preview and duplicate handling, and workboard pagination. The focused checks and CI pass. Approved.