-
Notifications
You must be signed in to change notification settings - Fork 37
Fix bug in mesh refinement with multiple points #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
santisoler
wants to merge
7
commits into
main
Choose a base branch
from
fix-bug-refine-points
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c60315b
Patch `insert_cells` to consider multiple points
santisoler 096d15b
Update parameter description of `insert_cells`
santisoler f8e7874
Raise some sanity checks on levels and points
santisoler f4629a5
Fix usage of f-strings in error messages
santisoler ab9ebe2
Add tests for new errors
santisoler 6845ad1
Polish the code a bit
santisoler e1321e5
Add tests for the bugfix: refinement of mesh with multiple points
santisoler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just repeat a single integer up to the number of points. Otherwise this would allow you to pass more levels than points and cause a memory error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcapriot! Yes, I agree. I polished the code a bit.
The
_check_first_dim_broadcast(points=points, levels=levels)will ensure that there cannot be more levels than points (unless a single point is passed). I added an extra error message when a single point and multiple levels are passed, just to let the user know that there might be something off in their inputs.