Repository navigation
Fix product count issue - #108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The related-collections query lacks a multikey index on collections.$id, causing a full Product collection scan on each applicable page request with cost growing across all stored product versions.
1 open issue
What changed in this PR
Fixes incorrect product counts for parent and child collections by counting readable products directly rather than relying on hydrated links.
Changes:
- Adds an access-aware aggregation that avoids counting duplicate collection links.
- Passes computed counts to the collection-page template.
- Adds regression coverage for permissions, empty collections, shared memberships, and rendered counts.
| File | Description |
|---|---|
| tests/test_services/test_collection_counts.py | Tests service counts and rendered results across access levels. |
| hipposerve/web/templates/collection.html | Displays computed parent and child product counts. |
| hipposerve/web/__init__.py | Supplies related-collection counts to the template. |
| hipposerve/service/collection.py | Adds the access-filtered product-count aggregation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the production issue of product number being incorrect.
Co-authored with GPT 6.1 Sol