Skip to content

SF-3843 Add language code to serval builds search - #4091

Merged
RaymondLuong3 merged 1 commit into
masterfrom
feature/SF-3843-language-code-search
Sep 10, 2026
Merged

SF-3843 Add language code to serval builds search#4091
RaymondLuong3 merged 1 commit into
masterfrom
feature/SF-3843-language-code-search

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

This PR adds language codes to the searchable fields of serval builds in the serval administration page. Builds can be filtered using the source or target language codes.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.94%. Comparing base (2abfc40) to head (e2bdc97).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4091      +/-   ##
==========================================
- Coverage   80.94%   80.94%   -0.01%     
==========================================
  Files         664      664              
  Lines       42153    42153              
  Branches     6917     6944      +27     
==========================================
- Hits        34122    34121       -1     
- Misses       6881     6882       +1     
  Partials     1150     1150              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman
pmachapman self-requested a review September 9, 2026 01:22
@pmachapman pmachapman self-assigned this Sep 9, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Sep 9, 2026
@RaymondLuong3
RaymondLuong3 force-pushed the feature/SF-3843-language-code-search branch from 899e3b3 to 429e734 Compare September 10, 2026 15:41
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Sep 10, 2026
@RaymondLuong3
RaymondLuong3 force-pushed the feature/SF-3843-language-code-search branch from 429e734 to 98c6e32 Compare September 10, 2026 16:05
@RaymondLuong3
RaymondLuong3 force-pushed the feature/SF-3843-language-code-search branch from 98c6e32 to bb2900a Compare September 10, 2026 16:15
@RaymondLuong3
RaymondLuong3 force-pushed the feature/SF-3843-language-code-search branch from bb2900a to e2bdc97 Compare September 10, 2026 18:49
@RaymondLuong3
RaymondLuong3 deployed to screenshot_diff September 10, 2026 18:57 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

📸 Screenshot diff deployed! (1 change)

View the visual diff at: https://pr-4091--sf-screenshot-diffs.netlify.app

@RaymondLuong3
RaymondLuong3 merged commit c607c80 into master Sep 10, 2026
28 of 29 checks passed
@RaymondLuong3
RaymondLuong3 deleted the feature/SF-3843-language-code-search branch September 10, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants