SF-3920 Fix event metrics not being recorded for BuildCompletedAsync - #4079
Merged
Conversation
pmachapman
temporarily deployed
to
screenshot_diff
August 31, 2026 03:17 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 664 664
Lines 42115 42121 +6
Branches 6936 6936
=======================================
+ Hits 34088 34095 +7
+ Misses 6880 6879 -1
Partials 1147 1147 ☔ View full report in Codecov by Harness. |
pmachapman
force-pushed
the
fix/SF-3920
branch
from
September 6, 2026 21:33
a4f7429 to
c130697
Compare
pmachapman
temporarily deployed
to
screenshot_diff
September 6, 2026 21:41 — with
GitHub Actions
Inactive
Contributor
|
📸 Screenshot diff deployed! (2 changes) View the visual diff at: https://pr-4079--sf-screenshot-diffs.netlify.app |
RaymondLuong3
approved these changes
Sep 8, 2026
RaymondLuong3
left a comment
Collaborator
There was a problem hiding this comment.
@RaymondLuong3 reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
Nateowami
force-pushed
the
fix/SF-3920
branch
from
September 9, 2026 14:39
c130697 to
90aec91
Compare
Nateowami
enabled auto-merge (squash)
September 9, 2026 14:39
Nateowami
temporarily deployed
to
screenshot_diff
September 9, 2026 14:46 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I noticed on live where the following error was being logged in the journal:
This error doesn't prevent builds from completing, but will prevent the recording of the BuildCompletedAsync event metric.
This change is