Fix chain of unsaved-changes prompts when opening the formula editor - #1111
Open
robertisele wants to merge 2 commits into
Open
Fix chain of unsaved-changes prompts when opening the formula editor#1111robertisele wants to merge 2 commits into
robertisele wants to merge 2 commits into
Conversation
…for a new mapping After saving a new value mapping via the pen icon, the mapping list reloads while the formula editor mounts. Every list row issued a router navigation on mount and the editor reported unsaved changes until it had initialized, so each navigation raised the "unsaved changes" confirm, once per rule. - DraggableItem: rows that mount collapsed no longer touch the URL. - RuleEditorModel: no unsaved changes are reported while the editor is initializing. CMEM-8143 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013CoCMG72HzZRnv4fzh6RtV
robertisele
changed the title
Since the editor no longer reports unsaved changes while initializing, the Save button is disabled from the first render, so waiting for it no longer waits for the rule to load. Wait for the node on the canvas instead. CMEM-8143 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAGwGNnrBJFSUwz1DwHmea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.