[gadfort]

Summary by CodeRabbit

• New Features

  • Added release-bundle support for the Coral NPU design, including organized component, dependency, and source management.
  • Added a parameterized SRAM interface with byte-mask write support and registered read-valid signaling.

• Bug Fixes

  • Updated timing constraints to use the correct io_aclk clock input.
  • Updated the ASAP7 clock period constraint for improved timing accuracy.

• Refactor

  • Removed legacy, fixed-size SRAM module variants in favor of the unified SRAM interface.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: c84e4065-7517-4fb2-93bb-383a707105b4

📥 Commits

Reviewing files that changed from the base of the PR and between 37eb4d9 and 5e9d29d.

📒 Files selected for processing (10)

• scgallery/designs/coralnpu/constraints/asap7sc7p5t_rvt.sdc
• scgallery/designs/coralnpu/constraints/gf180mcu_fd_sc_mcu7t5v0.sdc
• scgallery/designs/coralnpu/constraints/gf180mcu_fd_sc_mcu9t5v0.sdc
• scgallery/designs/coralnpu/constraints/nangate45.sdc
• scgallery/designs/coralnpu/constraints/sg13g2_stdcell.sdc
• scgallery/designs/coralnpu/constraints/sky130hd.sdc
• scgallery/designs/coralnpu/coralnpu.py
• scgallery/designs/coralnpu/extra/Sram.v
• scgallery/designs/coralnpu/extra/lambda.v
• scgallery/designs/coralnpu/pickle/CoralNPUChiselSubsystem.sv

💤 Files with no reviewable changes (1)

• scgallery/designs/coralnpu/extra/lambda.v

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The Coral NPU design now uses release-based library manifests and a new SRAM wrapper. The top-level hierarchy assembles scalar, vector, memory, and AXI components. ASIC targets use simplified synthesis settings, and timing constraints reference io_aclk.

Changes

Coral NPU release integration

Layer / File(s)	Summary
Release metadata and shared libraries scgallery/designs/coralnpu/coralnpu.py	Added release metadata and manifests for Coral NPU cells and floating-point sources.
SRAM library integration scgallery/designs/coralnpu/coralnpu.py, scgallery/designs/coralnpu/extra/Sram.v	Added the parameterized Sram wrapper and connected it to the memory library through the Spram dependency.
Core and AXI hierarchy scgallery/designs/coralnpu/coralnpu.py	Added scalar-core, vector-backend, vector-core, and AXI top-level wiring. The design uses RvvCoreMiniAxi as its top module.
Timing and synthesis configuration scgallery/designs/coralnpu/coralnpu.py, scgallery/designs/coralnpu/constraints/*.sdc	Removed per-target Yosys overrides, enabled SystemVerilog parsing, and changed the clock port constraints to io_aclk. The ASAP7 clock period is now 1000.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 5e9d2

The updated constraints target the released top-level clock interface, with no remaining merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 1 files. (7 skipped: 7…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: migrating Coral NPU to a released artifact-based implementation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 1 files. (7 skipped: 7 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch coral

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}