Skip to content

Seven calling methods accept a missing control_id that the API requires #99

Description

@hey-august

Summary

The play(), record(), collect(), detect(), tap(), stream(), and transcribe() methods on the calling namespace declare control_id: str | None = None. The Calling API requires the field on all seven commands.

Why it matters

  • The public OpenAPI lists params.control_id as required on each of these requests.
  • A command sent without it is rejected server-side.
  • The endpoint accepts commands asynchronously, so the request still returns success. Nothing at call time or in the response tells the developer anything went wrong.

The corresponding stop methods already require the argument, which is the correct shape.

Not affected

The ai_stop() method is correct as written. The API does not require control_id on that command.

Root cause

The spec the generator reads marks the field optional. That is tracked in signalwire/porting-sdk#143. This issue tracks the regenerate here once the spec change is merged.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions