fix(core/content-header): Fix responsive content-header behavior - #2702
Open
dmytro-halimov wants to merge 3 commits into
Open
fix(core/content-header): Fix responsive content-header behavior#2702dmytro-halimov wants to merge 3 commits into
dmytro-halimov wants to merge 3 commits into
Conversation
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: f5f7a05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesThe content header now wraps title and subtitle text by default. It supports optional single-line truncation with native tooltips. Public typings, Angular bindings, framework previews, tests, visual fixtures, and release metadata were updated. Content header text behavior
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Oz <oz-agent@warp.dev>
dmytro-halimov
force-pushed
the
fix/content-header-responsive-fix
branch
from
August 6, 2026 07:57
fe458fa to
7e69f2e
Compare
dmytro-halimov
marked this pull request as ready for review
August 6, 2026 08:06
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@testing/visual-testing/tests/content-header/basic/index.html`:
- Around line 17-21: Replace the hard-coded 2rem gap in the body rule with the
existing spacing design token or CSS custom property used by the theme. Keep the
grid layout and width unchanged, and reuse the established token rather than
introducing a new one.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6a5a8dd1-2b53-4ce1-8a56-f2e90f80b31e
⛔ Files ignored due to path filters (8)
packages/angular/standalone/src/components.tsis excluded by!packages/angular/standalone/src/components.tspackages/react/src/components/components.server.tsis excluded by!packages/react/src/components/**packages/vue/src/components/ix-content-header.tsis excluded by!packages/vue/src/components/**testing/framework-tests/tests/generated/axe.tsis excluded by!**/generated/**testing/framework-tests/tests/generated/content-header-truncate-axe.spec.tsis excluded by!**/generated/**testing/framework-tests/tests/generated/content-header-truncate.spec.tsis excluded by!**/generated/**testing/framework-tests/tests/generated/index.tsis excluded by!**/generated/**testing/framework-tests/tests/generated/test-ids.autogenerated.tsis excluded by!**/generated/**
📒 Files selected for processing (29)
.changeset/content-header-responsive-text.mdpackages/angular-standalone-test-app/src/app/app.routes.tspackages/angular-standalone-test-app/src/preview-examples/content-header-truncate.htmlpackages/angular-standalone-test-app/src/preview-examples/content-header-truncate.tspackages/angular-standalone-test-app/src/preview-examples/content-header.htmlpackages/angular-test-app/src/app/app-routing.module.tspackages/angular-test-app/src/app/app.module.tspackages/angular-test-app/src/preview-examples/content-header-truncate.htmlpackages/angular-test-app/src/preview-examples/content-header-truncate.tspackages/angular-test-app/src/preview-examples/content-header.htmlpackages/angular/src/components.tspackages/core/src/components.d.tspackages/core/src/components/content-header/content-header.scsspackages/core/src/components/content-header/content-header.tsxpackages/core/src/components/content-header/content-header.types.tspackages/core/src/components/content-header/test/content-header.ct.tspackages/html-test-app/src/preview-examples/content-header-truncate.htmlpackages/html-test-app/src/preview-examples/content-header.htmlpackages/react-test-app/src/main.tsxpackages/react-test-app/src/preview-examples/content-header-truncate.tsxpackages/react-test-app/src/preview-examples/content-header.tsxpackages/vue-test-app/src/Root.vuepackages/vue-test-app/src/preview-examples/content-header-truncate.vuepackages/vue-test-app/src/preview-examples/content-header.vuetesting/framework-tests/__snapshots__/content-header-aria-snapshot.yamltesting/framework-tests/__snapshots__/content-header-truncate-aria-snapshot.yamltesting/framework-tests/tests/working-with-axe.spec.tstesting/framework-tests/tests/working.spec.tstesting/visual-testing/tests/content-header/basic/index.html
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs PR: siemens/ix-docs#273
💡 What is the current behavior?
The title and subtitle of content-header component are truncated/ellipsized by default. This differs from the expected Figma behavior and makes the responsive behavior unclear.
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support
Summary by CodeRabbit
New Features
textOverflow="truncate"with native tooltips showing complete text.Bug Fixes
Tests