feat(core): eliminate global styles - #2632
Conversation
🦋 Changeset detectedLatest commit: 77f1997 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the styling architecture of the @siemens/ix package by introducing new foundation and legacy utility CSS entry points (siemens-ix-foundation.css and siemens-ix-legacy-utilities.css) to facilitate incremental migration. It also modularizes component styling by moving token defaults from the global theme output into dedicated component *.vars.scss files using local --ix-* custom properties. Additionally, a test button has been added to the ix-playground component. No review comments were provided, so I have no feedback to offer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@coderabbitai review |
✅ Action performedReview finished.
|
kathrinschalber
left a comment
kathrinschalber
left a comment
There was a problem hiding this comment.
A few things that need to be checked.
There was a problem hiding this comment.
striped style is gone
There was a problem hiding this comment.
[ToDo in Theme generator] Border is not visible anymore -> change token for readonly
There was a problem hiding this comment.
Is correctly set, @silviowolf would it make sense to the ref-token for border-4 in classic theme? it's barely visible....
There was a problem hiding this comment.
how did the input field (color-component-8) change?
There was a problem hiding this comment.
Similar to category filter -> border in readonly/disabled
There was a problem hiding this comment.
Will be fixed via token update
There was a problem hiding this comment.
was this intentional, that the checkbox has no background (anymore)?
There was a problem hiding this comment.
Need to be check if v6 still supports legacy native input element, maybe need deprecation blog/post.
There was a problem hiding this comment.
Textarea (light theme) stayed colored, in contrast to e.g. selects
There was a problem hiding this comment.
Textarea test covers the legacy native components not the ix-textarea. Will maybe be removed with v6
There was a problem hiding this comment.
For 6.0, doublecheck:
- app header background-3
- app menu background-2
There was a problem hiding this comment.
Is already aligend with element. background-1 is correct. Figma needs to be adapted
There was a problem hiding this comment.
Fonts in critical variant should be all white. Also, to me they look not at all similar to the Figma
There was a problem hiding this comment.
Light theme is correct, but in dark theme critical should have a white font as well
There was a problem hiding this comment.
the icon should turn orange too
There was a problem hiding this comment.
Need to be adapted inside input-helper-new.json of the token json
There was a problem hiding this comment.
Shadow on dropdown is not visible (dark mode only)
There was a problem hiding this comment.
Shadow exist also in darkmode, but due the background color change, its not visible anymore
There was a problem hiding this comment.
@silviowolf please validate whether
- border colors should be used for the lines and text for the icons, and
- if we need a better matching color for the selected step (should the dot be also gray?)
PS: Also see the dark version of this: testing/visual-testing/screenshots/tests/workflow-steps/workflow-steps.e2e.ts/workflow-steps-basic-1-chromium---classic-dark-linux.png
There was a problem hiding this comment.
icon is decorative -> change to background tokens
1189b90 to
b31df5f
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
2 participants
🆕 What is the new behavior?
ToDo
--themeprefix from color variables (required icon change feat(icon): remove prefix of color icon ix-icons#121)🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)Related
👨💻 Help & support