Skip to content

feat(core/application): Adjust skip link implementation #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmytro-halimov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(core/application): Adjust skip link implementation #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/angular-starter/src/app/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<a href="#main-content" class="skip-link">Skip to main content</a>
<ix-application>
<ix-application skipLinkTargetId="main-content">
<ix-application-header name="Siemens Industrial Experience Starter App">
@if (showLogo) {
<app-company-logo slot="logo"></app-company-logo>
Expand Down
16 changes: 0 additions & 16 deletions apps/angular-starter/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,6 @@ body {
outline: var(--theme-color-focus-bdr);
}

.skip-link {
position: absolute;
top: -40px;
left: 0;
background: var(--theme-color-1);
color: var(--theme-color-std-text);
padding: 8px 16px;
z-index: 10000;
text-decoration: none;
font-weight: 600;
}

.skip-link:focus {
top: 0;
}

.sr-only {
position: absolute;
width: 1px;
Expand Down
16 changes: 0 additions & 16 deletions apps/react-starter/src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,6 @@ body,
outline: var(--theme-color-focus-bdr);
}

.skip-link {
position: absolute;
top: -40px;
left: 0;
background: var(--theme-color-1);
color: var(--theme-color-std-text);
padding: 8px 16px;
z-index: 10000;
text-decoration: none;
font-weight: 600;
}

.skip-link:focus {
top: 0;
}

.sr-only {
position: absolute;
width: 1px;
Expand Down
119 changes: 57 additions & 62 deletions apps/react-starter/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,70 +23,65 @@ function App() {
const isActive = (path: string): boolean => location.pathname === path;

return (
<>
<a href="#main-content" className="skip-link">
Skip to main content
</a>
<IxApplication>
<IxApplicationHeader name="Siemens Industrial Experience Starter App">
<CompanyLogo />
<IxAvatar initials="JD" aria-label="User avatar: JD" />
</IxApplicationHeader>
<IxApplication skipLinkTargetId="main-content">
<IxApplicationHeader name="Siemens Industrial Experience Starter App">
<CompanyLogo />
<IxAvatar initials="JD" aria-label="User avatar: JD" />
</IxApplicationHeader>

<IxMenu enableToggleTheme aria-label="Main navigation">
<IxMenuItem
icon={iconHome}
active={isActive('/')}
onClick={e => {
e.preventDefault();
navigate('/');
}}
>
Get Started
</IxMenuItem>
<IxMenuItem
icon={iconTextDocument}
active={isActive('/forms')}
onClick={e => {
e.preventDefault();
navigate('/forms');
}}
>
Forms
</IxMenuItem>
<IxMenuItem
icon={iconPiechart}
active={isActive('/charts')}
onClick={e => {
e.preventDefault();
navigate('/charts');
}}
>
Charts
</IxMenuItem>
<IxMenuItem
icon={iconTable}
active={isActive('/grids')}
onClick={e => {
e.preventDefault();
navigate('/grids');
}}
>
Grids
</IxMenuItem>
</IxMenu>
<IxMenu enableToggleTheme aria-label="Main navigation">
<IxMenuItem
icon={iconHome}
active={isActive('/')}
onClick={e => {
e.preventDefault();
navigate('/');
}}
>
Get Started
</IxMenuItem>
<IxMenuItem
icon={iconTextDocument}
active={isActive('/forms')}
onClick={e => {
e.preventDefault();
navigate('/forms');
}}
>
Forms
</IxMenuItem>
<IxMenuItem
icon={iconPiechart}
active={isActive('/charts')}
onClick={e => {
e.preventDefault();
navigate('/charts');
}}
>
Charts
</IxMenuItem>
<IxMenuItem
icon={iconTable}
active={isActive('/grids')}
onClick={e => {
e.preventDefault();
navigate('/grids');
}}
>
Grids
</IxMenuItem>
</IxMenu>

<IxContent id="main-content">
<Routes>
<Route path="/" element={<GetStarted />} />
<Route path="/forms" element={<Forms />} />
<Route path="/charts" element={<Charts />} />
<Route path="/grids" element={<Grids />} />
<Route path="*" element={<GetStarted />} />
</Routes>
</IxContent>
</IxApplication>
</>
<IxContent id="main-content">
<Routes>
<Route path="/" element={<GetStarted />} />
<Route path="/forms" element={<Forms />} />
<Route path="/charts" element={<Charts />} />
<Route path="/grids" element={<Grids />} />
<Route path="*" element={<GetStarted />} />
</Routes>
</IxContent>
</IxApplication>
);
}

Expand Down
3 changes: 1 addition & 2 deletions apps/vue-starter/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ const route = useRoute();
</script>

<template>
<a href="#main-content" class="skip-link">Skip to main content</a>
<IxApplication>
<IxApplication skipLinkTargetId="main-content">
<IxApplicationHeader name="Siemens Industrial Experience Starter App">
<CompanyLogo />
<IxAvatar initials="JD" aria-label="User avatar: JD" />
Expand Down
16 changes: 0 additions & 16 deletions apps/vue-starter/src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,6 @@ body,
outline: var(--theme-color-focus-bdr);
}

.skip-link {
position: absolute;
top: -40px;
left: 0;
background: var(--theme-color-1);
color: var(--theme-color-std-text);
padding: 8px 16px;
z-index: 10000;
text-decoration: none;
font-weight: 600;
}

.skip-link:focus {
top: 0;
}

.sr-only {
position: absolute;
width: 1px;
Expand Down
3 changes: 1 addition & 2 deletions packages/create-siemens-web/template-ix-angular-starter/src/app/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<a href="#main-content" class="skip-link">Skip to main content</a>
<ix-application>
<ix-application skipLinkTargetId="main-content">
<ix-application-header name="Siemens Industrial Experience Starter App">
@if (showLogo) {
<app-company-logo slot="logo"></app-company-logo>
Expand Down
16 changes: 0 additions & 16 deletions packages/create-siemens-web/template-ix-angular-starter/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,6 @@ body {
outline: var(--theme-color-focus-bdr);
}

.skip-link {
position: absolute;
top: -40px;
left: 0;
background: var(--theme-color-1);
color: var(--theme-color-std-text);
padding: 8px 16px;
z-index: 10000;
text-decoration: none;
font-weight: 600;
}

.skip-link:focus {
top: 0;
}

.sr-only {
position: absolute;
inline-size: 1px;
Expand Down
16 changes: 0 additions & 16 deletions packages/create-siemens-web/template-ix-react-starter/src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,6 @@ body,
outline: var(--theme-color-focus-bdr);
}

.skip-link {
position: absolute;
top: -40px;
left: 0;
background: var(--theme-color-1);
color: var(--theme-color-std-text);
padding: 8px 16px;
z-index: 10000;
text-decoration: none;
font-weight: 600;
}

.skip-link:focus {
top: 0;
}

.sr-only {
position: absolute;
inline-size: 1px;
Expand Down
119 changes: 57 additions & 62 deletions packages/create-siemens-web/template-ix-react-starter/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,70 +23,65 @@ function App() {
const isActive = (path: string): boolean => location.pathname === path;

return (
<>
<a href="#main-content" className="skip-link">
Skip to main content
</a>
<IxApplication>
<IxApplicationHeader name="Siemens Industrial Experience Starter App">
<CompanyLogo />
<IxAvatar initials="JD" aria-label="User avatar: JD" />
</IxApplicationHeader>
<IxApplication skipLinkTargetId="main-content">
<IxApplicationHeader name="Siemens Industrial Experience Starter App">
<CompanyLogo />
<IxAvatar initials="JD" aria-label="User avatar: JD" />
</IxApplicationHeader>

<IxMenu enableToggleTheme aria-label="Main navigation">
<IxMenuItem
icon={iconHome}
active={isActive('/')}
onClick={e => {
e.preventDefault();
navigate('/');
}}
>
Get Started
</IxMenuItem>
<IxMenuItem
icon={iconTextDocument}
active={isActive('/forms')}
onClick={e => {
e.preventDefault();
navigate('/forms');
}}
>
Forms
</IxMenuItem>
<IxMenuItem
icon={iconPiechart}
active={isActive('/charts')}
onClick={e => {
e.preventDefault();
navigate('/charts');
}}
>
Charts
</IxMenuItem>
<IxMenuItem
icon={iconTable}
active={isActive('/grids')}
onClick={e => {
e.preventDefault();
navigate('/grids');
}}
>
Grids
</IxMenuItem>
</IxMenu>
<IxMenu enableToggleTheme aria-label="Main navigation">
<IxMenuItem
icon={iconHome}
active={isActive('/')}
onClick={e => {
e.preventDefault();
navigate('/');
}}
>
Get Started
</IxMenuItem>
<IxMenuItem
icon={iconTextDocument}
active={isActive('/forms')}
onClick={e => {
e.preventDefault();
navigate('/forms');
}}
>
Forms
</IxMenuItem>
<IxMenuItem
icon={iconPiechart}
active={isActive('/charts')}
onClick={e => {
e.preventDefault();
navigate('/charts');
}}
>
Charts
</IxMenuItem>
<IxMenuItem
icon={iconTable}
active={isActive('/grids')}
onClick={e => {
e.preventDefault();
navigate('/grids');
}}
>
Grids
</IxMenuItem>
</IxMenu>

<IxContent id="main-content">
<Routes>
<Route path="/" element={<GetStarted />} />
<Route path="/forms" element={<Forms />} />
<Route path="/charts" element={<Charts />} />
<Route path="/grids" element={<Grids />} />
<Route path="*" element={<GetStarted />} />
</Routes>
</IxContent>
</IxApplication>
</>
<IxContent id="main-content">
<Routes>
<Route path="/" element={<GetStarted />} />
<Route path="/forms" element={<Forms />} />
<Route path="/charts" element={<Charts />} />
<Route path="/grids" element={<Grids />} />
<Route path="*" element={<GetStarted />} />
</Routes>
</IxContent>
</IxApplication>
);
}

Expand Down
Loading
Loading