Skip to content

Move the x_label below the item detail label if they overlap near the top of the chart #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulcadman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move the x_label below the item detail label if they overlap near the top of the chart #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/js/Rickshaw.Graph.HoverDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,25 @@ Rickshaw.Graph.HoverDetail = Rickshaw.Class.create({
}
}

var collisions = this._calcLayoutCollisions(alignables);
if (collisions.length !== 0) {
// There's a collision between the item and x_label.
// This happens when a datapoint appears near the top of the chart.
// The item and x_label are aligned horizontally so to avoid the collision
// we move the x_label below the item.

var parentRect = this.element.parentNode.getBoundingClientRect();
var itemRect = item.getBoundingClientRect();
// The following assumes that the x_label is positioned absolutely
// with respect its parent element.

// To move the x_label above the item use the following position instead:
// xlabelRect = xLabel.getBoundingClientRect();
// topPosition = itemRect.top - (xlabelRect.bottom - xlabelRect.top) - parentRect.top;
var topPosition = itemRect.bottom - parentRect.top;
xLabel.style.top = topPosition + "px";
}

if (typeof this.onRender == 'function') {
this.onRender(args);
}
Expand Down Expand Up @@ -251,6 +270,28 @@ Rickshaw.Graph.HoverDetail = Rickshaw.Class.create({
return error;
},

_calcLayoutCollisions: function(alignables) {
// return pairs of elements among alignables that overlap
var collisions = [];
var a1, a2, r1, r2;

for (var i=0; i<alignables.length; i++) {
a1 = alignables[i];
r1 = a1.getBoundingClientRect();
for (var j=i+1; j<alignables.length; j++) {
a2 = alignables[j];
r2 = a2.getBoundingClientRect();
if (!(r1.right < r2.left ||
r1.left > r2.right ||
r1.bottom < r2.top ||
r1.top > r2.bottom)) {
collisions.push([a1, a2]);
}
}
}
return collisions;
},

_addListeners: function() {

this.graph.element.addEventListener(
Expand Down