fix: align "No content" table with the base and panel count - #289
Open
MeGaurav4 wants to merge 1 commit into
Open
fix: align "No content" table with the base and panel count#289MeGaurav4 wants to merge 1 commit into
MeGaurav4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty file (e.g.
/dev/null) renders a "No content" row whose cell widths were hardcoded for the hexadecimal base with two panels, so the row no longer matched the table borders.Root cause: the empty-file branch forced
base_digits = 2(hex width) and only ever rendered one panel's worth of cells, regardless of the configured base and panel count.Fix: drop the hardcoded base override and render one cell per panel using
panel_sz(), so the "No content" row matches the borders for every base (binary, octal, decimal, hexadecimal) and any panel count.Only
src/lib.rsis changed, plus 3 regression tests for non-hex empty-file output.Closes #288
Verification
hexyl /dev/null --base=binary|octal|decimal|hexadecimalall render aligned tablesempty_file_passestest passes unchanged)cargo test --all: 59 passed (13 lib + 5 parser + 41 integration)