Skip to content

nixfmt test - #23

Open
kirelagin wants to merge 28 commits into
masterfrom
kirelagin/fmt-test
Open

nixfmt test#23
kirelagin wants to merge 28 commits into
masterfrom
kirelagin/fmt-test

Conversation

@kirelagin

@kirelagin kirelagin commented Oct 26, 2019

Copy link
Copy Markdown
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

yorickvP and others added 28 commits October 10, 2019 12:44
@yorickvP
services/buildkite-agent: update service for buildkite 3
f66c1e4
@lukateras @yorickvP
buildkite-agent: make ssh key optional, remove public key option
1a517be
@yorickvP
buildkite-agent2: drop
573a499
Christian Höppner @yorickvP
buildkite-agent: change option meta-data into tags attrset
2e74267
@yorickvP
nixos/buildkite-agents: add module, remove buildkite-agent module
024b61c
@Lucus16 @yorickvP
buildkite-agents: Improve documentation
da55b5c
@flokli @yorickvP
nixos/buildkite-agents: remove PermissionsStartOnly, setup dataDir vi…
51d520d 
…a StateDirectory
@flokli @yorickvP
nixos/buildkite-agents: remove deprecated usage of types.string
5e88891
@flokli @yorickvP
nixos/buildkite-agents: fix documentation, defaultTexts
4d1d59d
@flokli @yorickvP
nixos/buildkite-agents: remove legacy tag syntax
944f5bb 
The module has already changed significantly anyways.
@flokli @yorickvP
nixos/buildkite-agents: prefix buildkite- to usernames
b728ad3 
It would be weird for it to e.g. allocate a user named foo just because
one uses foo as the attribute name.
@flokli @yorickvP
nixos/buildkite-agents: move toString to apply attribute of sshKeyPath
aafcfbb
@flokli @yorickvP
nixos/buildkite-agents: move mkRemovedOptionModule for old module to …
43b3420 
…imports
@flokli @yorickvP
buildkite-agent2: provide throw for removed attribute
527b943
@flokli @yorickvP
nixos/tests: add buildkite-agents test
0a51583
@lukateras @yorickvP
nixos/nginx: make sslCertificate and sslCertificateKey nullable
c46bca9 
NixOS#40932
@yorickvP
nixos/borgbackup: generate wrappers per job for easy borg access
43ffdd6
@yorickvP
nixos/alertmanager: add environmentFile, substituteAll for secrets
b59a443
Christian Höppner @yorickvP
docker-containers.nix: Give containers more reasonable names
57c1877
Christian Höppner @yorickvP
docker.nix: Add options for named volumes and networks
639092d
Christian Höppner @yorickvP
docker.nix: do not fail the unit if removing a volume fails
4c0b97d
Christian Höppner @yorickvP
docker-containers.nix: always pull explicitly before starting a conta…
06c09b2 
…iner
Christian Höppner @yorickvP
Allow docker-containers to use image derivations directly
f9db075
@yorickvP
buildkite-agents: remove rename
f9a5667
@yorickvP
substituteAll: separate into file instead of using from setup.sh
d1e358c
@yorickvP
buildkite: fix names
c2ee33c
@yorickvP
buildkite-agents: fix module
a13e14f
@kirelagin
nixfmt test
df37062
@kirelagin

kirelagin commented Oct 26, 2019

Copy link
Copy Markdown
Author

Yo @nixfmt

@kirelagin

kirelagin commented Oct 26, 2019

Copy link
Copy Markdown
Author

Yoyoyo @nixfmt

@Haskell-mouse

Haskell-mouse commented Oct 26, 2019

Copy link
Copy Markdown

@nixfmt

1 similar comment
@mkaito

mkaito commented Oct 26, 2019

Copy link
Copy Markdown

@nixfmt

@zhenyavinogradov
zhenyavinogradov force-pushed the master branch 2 times, most recently from d064efc to 1714a2e Compare September 10, 2021 13:38
@PhilTaken
PhilTaken force-pushed the master branch 3 times, most recently from 0c9ef26 to 1dfdbb6 Compare February 2, 2023 09:51
@karandit
karandit force-pushed the master branch 2 times, most recently from 0f42a54 to bc91979 Compare December 5, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kirelagin @Haskell-mouse @mkaito @yorickvP @lukateras @Lucus16 @flokli