Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Improve backwards compatibility - #15

Open
cyberixae wants to merge 1 commit into
sergiodxa:masterfrom
cyberixae:improve_backwards_compatibility
Open

Improve backwards compatibility#15
cyberixae wants to merge 1 commit into
sergiodxa:masterfrom
cyberixae:improve_backwards_compatibility

Conversation

@cyberixae

@cyberixae cyberixae commented Nov 20, 2019

Copy link
Copy Markdown

This PR migrates type definitions from Definitely typed to the project code base.

@cyberixae
cyberixae force-pushed the improve_backwards_compatibility branch from d0136f6 to ecc8227 Compare November 20, 2019 14:41
@cyberixae

Copy link
Copy Markdown
Author

I modified the structure of createDuck a bit. The benefit is that we can simply state that it returns a DuckBuilder rather than having to define types inline around the code base. I also remove most type signatures from the existing test and added a new properly typed test. The logic here is that the user can choose whether they want to live in a strongly typed world or a more loosely typed one where we attempt to infer everything for the user. These two need to be tested separately. Otherwise one or the other might break if something changes in the future.

@cyberixae

Copy link
Copy Markdown
Author

Did you have a chance to take a look at this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant