chore: remove local AI-assistant configuration from the repo, keep the engineering rules - #180
Merged
Merged
Conversation
…e engineering rules This repo is public, and the orchestration setup I run against it is personal tooling, not part of the project. It should never have been tracked. Removing it. Untracked (still on disk locally, now gitignored): .agent/, .claude/, CLAUDE.md, AGENTS.md, .cursorrules, and design-docs/how-this-system-works.md. That last one was the real exposure: 151 lines of plain-language manual describing the assistant roles, their mandate, and the model-tier strategy, sitting in a public repo and in neither of the two directories anyone would think to check. Kept, because it documents this codebase rather than my tooling: the thirteen engineering-rule files move to design-docs/engineering-rules/ with a router README. Backend and frontend boundaries, module architecture, verification, code review. Anyone working on this code wants those. Every citation across specs, ADRs, plans, CONTRIBUTING.md, and source comments is repointed; references to files that did not survive the split are reworded rather than left dangling. Also scrubbed private assistant role names out of source comments, test docstrings, plan docs, and the wiki changelog, keeping each technical claim and dropping the attribution. The published handbook's "Repository Agent Rules" page is now "Engineering Rules" and no longer describes an assistant system. History is not rewritten. Squash-merging 2.0 into main resolves it, and deleting the studio-2.0 branch at release finishes the job. Verified: ruff clean, eslint 0 errors, 42 tests pass across every touched module, and no tracked file references .agent/, .claude/, CLAUDE.md, AGENTS.md, or any of the private role names.
This branch predates the entire Harry Potter roster rename (PR #186) and the 46 persona agent folders (PR #185), both already merged. Extending the same treatment here so nothing from that later work stays exposed: - Untrack the 9 renamed agent profiles and 46 persona identity.md files under .claude/agents/, same as the original 9 profiles this PR already removed. - Untrack design-docs/how-this-system-works.md and add it to .gitignore. This PR's own commit message already claimed this file (the one it calls "the real exposure") was untracked and gitignored, but the actual diff never touched it -- it was still fully tracked, with its content now describing the Harry Potter roster by name. Fixing that gap here, not introduced by tonight's session. - .claude/decisions/ (OD-0023 through OD-0028) needed no separate action, already covered by the existing broad /.claude/ gitignore rule. Not touched, left as an open question for the owner: design-docs/plans/active/roster-rename/, the plan documenting the rename itself. Unlike the files above, it's a project-record artifact (comparable to any other tracked plan doc), not part of the assistant's own operating configuration, so the same removal logic doesn't obviously apply -- but it does contain the full character mapping, so it's worth an explicit call rather than a silent default either way.
senigami
force-pushed
the
chore/remove-agent-layer-from-repo
branch
from
August 16, 2026 15:00
bbec6bb to
46bc10e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo is public. The AI-assistant configuration I run against it is personal tooling, not part of the project, and it should never have been tracked. This removes it and keeps the parts that document the codebase itself.
What came out
Untracked and gitignored (still present locally, nothing lost):
.agent/,.claude/,CLAUDE.md,AGENTS.md,.cursorrules.Two more that a directory-shaped rule would have missed:
design-docs/how-this-system-works.mdwas the real exposure. 151 lines of plain-language manual describing the assistant roles, the mandate, and the model-tier strategy, public since 2026-07-18 and in neither of the two directories anyone would think to check.design-docs/plans/active/sd2_claude_md_task_inventory/, a plan whose only deliverable was correcting the now-untracked guidance file.What stayed
The thirteen engineering-rule files move to
design-docs/engineering-rules/with a router README. Backend and frontend boundaries, module architecture, verification, code review. These describe how to change this codebase, so anyone working on it wants them.Every citation across
design-docs/specs/, the ADRs, the active plans,CONTRIBUTING.md, and source comments is repointed at the new location. Citations of files that did not survive the split are reworded rather than left as broken pointers.Private assistant role names are scrubbed from source comments, test docstrings, roughly 45 plan docs, and the wiki changelog, keeping every technical claim and dropping only the attribution. The published handbook page "Repository Agent Rules" is now "Engineering Rules" and no longer describes an assistant system.
What this does not do
History is not rewritten, by choice. Squash-merging
studio-2.0intomainresolves the tracking, and deleting thestudio-2.0branch at release finishes it. Note thatmainstill carries.agent/rules/(5 files) until then.Verification
./venv/bin/ruff check .: all checks passednpm -C frontend run lint: 0 errors (52 pre-existing warnings)pytestacross every touched module: 42 passed.agent/,.claude/,CLAUDE.md,AGENTS.md, and every private role name: zero hitsFor the reviewer
The scrub touched 115 files as comment and docstring text only, no logic. The two things worth a second look are
design-docs/engineering-rules/README.md(new, hand-written router) and the deleted code-map bullet inverification.md, which pointed at machinery that is no longer in the repo and has no replacement to point at.