fix(runners,tasks): critical runner/task requeue and finalization bugs#4006
Closed
cursor[bot] wants to merge 2 commits into
Closed
fix(runners,tasks): critical runner/task requeue and finalization bugs#4006cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
When every runner is at capacity, ErrAllRunnersBusy requeued tasks by enqueueing them while they still sat in the running set, then sending EventTypeRequeued from a defer. A periodic queue tick could ClaimAndDequeue the task in that window and start a second dispatch on the same TaskRunner. Release running/active bookkeeping before enqueueing and notify the pool synchronously, matching the reconciler requeue paths. Co-authored-by: Denis Gukov <fiftin@outlook.com>
…finalization Runner client: when applyTerminatedJobs emergency-stops a job and Run() unwinds with an error, the error path overwrote stopped with failed. Add finalizeAfterRun that respects an already-finished status. HA reconciler: when failTaskRunnerLost wins the finalize lock but the DB already has a terminal status, complete finalization instead of bailing so pool/Redis state and autorun children are not leaked. Harden offline requeue with a pre-mutation DB re-check and rollback on persist failure. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily critical-bug inspection found three pre-existing correctness bugs still present on
develop(unchanged since prior automation runs). New commits since 2026-07-04 (git URL validation, access-key env filter, docker lib name) were reviewed and do not introduce new critical issues.Bugs fixed
1. Duplicate dispatch on ErrAllRunnersBusy
Impact: When all runners are busy, a task requeued while still in the running set could be claimed by a concurrent queue tick, causing duplicate dispatch on the same
TaskRunner.Root cause:
TaskRunner.run()enqueued the task before releasing running/active bookkeeping;EventTypeRequeuedwas sent from a defer after the race window.Fix: Call
onTaskStop()beforeEnqueue(), and emitEventTypeRequeuedsynchronously (matching reconciler requeue paths).2. Stopped → failed after terminated_jobs
Impact: When a runner emergency-stops a job via
terminated_jobsandRun()returns an error, the error path overwrotestoppedwithfailed.Root cause:
job_pool.goalways set fail status on anyRun()error without checking if the job was already terminal.Fix: Add
finalizeAfterRun()that respects an already-finished status.3. HA pool state leak in failTaskRunnerLost
Impact: In HA mode, when the reconciler won the finalize lock but the DB already had a terminal status, finalization bailed early without releasing pool/Redis state or completing autorun children.
Root cause:
finalizeRemoteTaskLocked()only released stale pool state whenEnd != nilinside the HA-only branch.Fix: Always release stale pool state when
End != nil; complete finalization when DB is terminal butEndis unset.Validation
go test ./services/tasks/... ./services/runners/... ./db/... ./db_lib/...— all pass