fix(runners,tasks): critical requeue and finalization bugs#4005
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(runners,tasks): critical requeue and finalization bugs#4005cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
When every runner is at capacity, ErrAllRunnersBusy requeued tasks by enqueueing them while they still sat in the running set, then sending EventTypeRequeued from a defer. A periodic queue tick could ClaimAndDequeue the task in that window and start a second dispatch on the same TaskRunner. Release running/active bookkeeping before enqueueing and notify the pool synchronously, matching the reconciler requeue paths. Co-authored-by: Denis Gukov <fiftin@outlook.com>
…finalization Runner client: when applyTerminatedJobs emergency-stops a job and Run() unwinds with an error, the error path overwrote stopped with failed. Add finalizeAfterRun that respects an already-finished status. HA reconciler: when failTaskRunnerLost wins the finalize lock but the DB already has a terminal status, complete finalization instead of bailing so pool/Redis state and autorun children are not leaked. Harden offline requeue with a pre-mutation DB re-check and rollback on persist failure. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks validated fixes for three critical runner/task bugs still present on
develop.Bugs fixed
1. Duplicate dispatch on ErrAllRunnersBusy
When every runner is at capacity, requeueing a task enqueued it while it still sat in the running set, then sent
EventTypeRequeuedfrom a defer. A concurrent queue tick couldClaimAndDequeuethe task in that window and start a second dispatch on the sameTaskRunner.Fix: Release running/active bookkeeping via
onTaskStopbefore enqueueing and notify the pool synchronously.2. Stopped → failed on runner after terminated_jobs
When
applyTerminatedJobsemergency-stops a job andRun()unwinds with an error, the error path overwrotestoppedwithfailed.Fix: Add
finalizeAfterRunthat respects an already-finished status.3. HA pool state leak in failTaskRunnerLost
When
failTaskRunnerLostwins the finalize lock but the DB already has a terminal status, it bailed without completing finalization, leaking pool/Redis state and skipping autorun children.Fix: Complete finalization via
finalizeRemoteTaskLockedwhen status is already terminal.Validation
go test ./services/tasks/... ./services/runners/...— all passRecent commits inspected
Since last inspection (
8323a87d): OIDC dep bump, Renovate custommanager, Dockerfile paramiko — no new critical issues.