fix(runners,tasks): critical runner requeue and finalization bugs#4002
Closed
cursor[bot] wants to merge 2 commits into
Closed
fix(runners,tasks): critical runner requeue and finalization bugs#4002cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
When every runner is at capacity, ErrAllRunnersBusy requeued tasks by enqueueing them while they still sat in the running set, then sending EventTypeRequeued from a defer. A periodic queue tick could ClaimAndDequeue the task in that window and start a second dispatch on the same TaskRunner. Release running/active bookkeeping before enqueueing and notify the pool synchronously, matching the reconciler requeue paths. Co-authored-by: Denis Gukov <fiftin@outlook.com>
…finalization Runner client: when applyTerminatedJobs emergency-stops a job and Run() unwinds with an error, the error path overwrote stopped with failed. Add finalizeAfterRun that respects an already-finished status. HA reconciler: when failTaskRunnerLost wins the finalize lock but the DB already has a terminal status, complete finalization instead of bailing so pool/Redis state and autorun children are not leaked. Harden offline requeue with a pre-mutation DB re-check and rollback on persist failure. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Three critical correctness bugs in the runner/task lifecycle on
develop:Duplicate dispatch on
ErrAllRunnersBusy— When all runners are busy, tasks were re-enqueued while still in the running set. A concurrent queue tick couldClaimAndDequeuethe same task and start a second dispatch, causing duplicate Ansible/Terraform execution.Stopped → failed on runner client — When the server emergency-stops a job via
terminated_jobs,applyTerminatedJobssets status tostopped, but the subsequentRun()error path overwrote it tofailed.HA pool state leak in reconciler — When
failTaskRunnerLostwon the finalize lock but the DB already had a terminal status, it returned early without callingfinalizeRemoteTaskLocked, leaking running/active Redis state and skipping autorun children.Root cause
ErrAllRunnersBusy, offline runner, undispatched task) enqueued before releasing running/active bookkeeping, creating a race window.job_pool.gounconditionally setfailedon anyRun()error without checking if status was already terminal.Fix and validation
onTaskStopbefore enqueueing; notify pool synchronously withEventTypeRequeued.runningJob.finalizeAfterRun()to preserve already-finished status.finalizeRemoteTaskLockedwhen reconciler observes terminal DB status; harden offline requeue with DB re-check and rollback on persist failure.End != nilguard infinalizeRemoteTaskLockedoutside HA-only block.Tests
go test ./services/tasks/... ./services/runners/...— all pass