fix(runners,tasks): critical runner requeue and finalization bugs#4000
Closed
cursor[bot] wants to merge 2 commits into
Closed
fix(runners,tasks): critical runner requeue and finalization bugs#4000cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
When every runner is at capacity, ErrAllRunnersBusy requeued tasks by enqueueing them while they still sat in the running set, then sending EventTypeRequeued from a defer. A periodic queue tick could ClaimAndDequeue the task in that window and start a second dispatch on the same TaskRunner. Release running/active bookkeeping before enqueueing and notify the pool synchronously, matching the reconciler requeue paths. Co-authored-by: Denis Gukov <fiftin@outlook.com>
…finalization Runner client: when applyTerminatedJobs emergency-stops a job and Run() unwinds with an error, the error path overwrote stopped with failed. Add finalizeAfterRun that respects an already-finished status. HA reconciler: when failTaskRunnerLost wins the finalize lock but the DB already has a terminal status, complete finalization instead of bailing so pool/Redis state and autorun children are not leaked. Harden offline requeue with a pre-mutation DB re-check and rollback on persist failure. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three critical correctness bugs on
developin the task runner lifecycle that can cause duplicate task execution, incorrect terminal status, and leaked pool/Redis state in HA deployments.Bugs and impact
1. Duplicate dispatch on
ErrAllRunnersBusyWhen all runners are busy,
TaskRunner.runre-enqueued the task while it remained in the running set. A concurrent queue tick couldClaimAndDequeueand spawn a secondrun()goroutine, leading to duplicate Ansible/Terraform execution.2. Stopped tasks reported as failed on runner
After the server sent
terminated_jobs(e.g. force stop),applyTerminatedJobsset status tostoppedand killed the job. Whenjob.Runreturned an error, the runner error path overwrotestoppedwithfailed.3. HA pool state leak in
failTaskRunnerLostWhen the DB already had a terminal status,
failTaskRunnerLostreturned early without callingfinalizeRemoteTaskLocked, leaking running/active state and skipping autorun when the reconciler won the finalize lock race.Root cause
job_pool.godid not preserve an already-finished status afterRunreturned.failTaskRunnerLosttreated "already finished in DB" as a full no-op instead of completing cleanup.Fix
onTaskStopbeforeEnqueueon all requeue paths (ErrAllRunnersBusy, reconciler offline/undispatched requeue).runningJob.finalizeAfterRunto leave terminal statuses unchanged.finalizeRemoteTaskLockedwhen DB status is already finished; broadenfinalizeRemoteTaskLockedEnd check outside HA-only branch.Validation
go test ./services/tasks/... ./services/runners/...— all passErrAllRunnersBusyrequeue,finalizeAfterRun, HAfailTaskRunnerLost, and reconciler requeue edge cases