fix(tasks,runners): prevent duplicate dispatch and runner finalization leaks#3998
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(tasks,runners): prevent duplicate dispatch and runner finalization leaks#3998cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
When every runner is at capacity, ErrAllRunnersBusy requeued tasks by enqueueing them while they still sat in the running set, then sending EventTypeRequeued from a defer. A periodic queue tick could ClaimAndDequeue the task in that window and start a second dispatch on the same TaskRunner. Release running/active bookkeeping before enqueueing and notify the pool synchronously, matching the reconciler requeue paths. Co-authored-by: Denis Gukov <fiftin@outlook.com>
…finalization Runner client: when applyTerminatedJobs emergency-stops a job and Run() unwinds with an error, the error path overwrote stopped with failed. Add finalizeAfterRun that respects an already-finished status. HA reconciler: when failTaskRunnerLost wins the finalize lock but the DB already has a terminal status, complete finalization instead of bailing so pool/Redis state and autorun children are not leaked. Harden offline requeue with a pre-mutation DB re-check and rollback on persist failure. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Critical bug inspection found three correctness issues on
developfrom recent runner lifecycle work. This PR applies minimal fixes with regression tests.1. Duplicate task dispatch when all runners are busy (critical)
Impact: A remote task could be dispatched twice (e.g. Ansible/Terraform run in parallel on the same task ID) when every runner is at capacity.
Trigger:
ErrAllRunnersBusyrequeue enqueued the task while it remained in the running set; a concurrent 5s queue tick couldClaimAndDequeueand spawn a secondrun()goroutine beforeEventTypeRequeuedreleased running state.Fix: Call
onTaskStopbeforeEnqueue, sendEventTypeRequeuedsynchronously (same pattern as reconciler requeue paths).2. Runner reports failed instead of stopped after emergency stop
Impact: Tasks force-stopped via
terminated_jobswhileRun()was unwinding were reported asfailedinstead ofstopped.Trigger: Server sends
terminated_jobs→ runner setsstopped→Run()returns error → error path overwrote terminal status.Fix: Shared
finalizeAfterRunhelper respectsIsFinished()before applying status.3. HA reconciler leaks pool state when task already finished
Impact: In HA mode, when
failTaskRunnerLostwon the finalize lock but the DB already had a terminal status, running/active pool state leaked (capacity exhaustion, skipped autorun children).Fix: Call
finalizeRemoteTaskLockedon the finished early-return path; harden offline requeue with DB re-check and rollback on persist failure.Validation
go test ./services/tasks/... ./services/runners/...— all passTestTaskRunner_ErrAllRunnersBusy_ReleasesRunningBeforeEnqueue,TestRunningJob_finalizeAfterRun_*,TestFailTaskRunnerLost_HA(finished-with/without End),TestRequeueTaskRunnerOffline_HA_SkipsWhenDBShowsRunning, persist-error rollback assertions