-
Notifications
You must be signed in to change notification settings - Fork 0
fix(crm): QR de conexão WhatsApp para de depender só do webhook, +res… #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Polling never starts for the exact "webhook hasn't confirmed yet" case.
iniciarPolling()is only invoked whenr.qrBase64 || r.pairingCodeis truthy. ButgerarQrAction/reiniciarInstanciaActioncan legitimately returnok:truewith neither field set, specifically when Evolution accepted the request but didn't return the QR inline (the exact scenario the polling was built to cover, per those actions' own comments about waiting for the webhook). In that branch,avisoshows "aguardando o webhook confirmar", but nothing then polls the DB to pick upultimo_qr/ultimo_pairing_codeonce the webhook writes them — the user is stuck until they manually retry.🐛 Proposed fix
setErro(null) setAviso(r.erro ?? null) if (r.qrBase64) { setQrLocal(r.qrBase64) setPairingLocal(null) } if (r.pairingCode) { setPairingLocal(r.pairingCode) setQrLocal(null) } - if (r.qrBase64 || r.pairingCode) iniciarPolling() + // Sempre sonda: mesmo sem QR/código na resposta, o webhook pode + // escrever ultimo_qr/ultimo_pairing_code em segundos. + iniciarPolling()📝 Committable suggestion
🤖 Prompt for AI Agents