Cut per-read allocations on the flatkv EVM state view hot path #4163
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package flatkv | ||
|
|
||
| import ( | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/sei-protocol/sei-chain/sei-db/common/keys" | ||
| "github.com/sei-protocol/sei-chain/sei-db/proto" | ||
| gigatypes "github.com/sei-protocol/sei-chain/sei-db/state_db/giga/types" | ||
| "github.com/sei-protocol/sei-chain/sei-db/state_db/sc/flatkv/config" | ||
| ) | ||
|
|
||
| // benchView opens a view over a store holding one account with a nonce, a balance, a storage slot and | ||
| // 8 KiB of code, so each benchmark measures a cache-hit read. | ||
| func benchView(b *testing.B) (gigatypes.StateView, gigatypes.Address) { | ||
| b.Helper() | ||
| cfg := config.DefaultTestConfig(&testing.T{}) | ||
|
There was a problem hiding this comment. [suggestion] |
||
| cfg.DataDir = filepath.Join(b.TempDir(), "flatkv") | ||
| s, err := newCommitStoreWithWAL(b.Context(), cfg) | ||
| require.NoError(b, err) | ||
| require.NoError(b, s.LoadLatest()) | ||
| b.Cleanup(func() { require.NoError(b, s.Close()) }) | ||
| addr := addrN(1) | ||
| code := make([]byte, 8*1024) | ||
| for i := range code { | ||
| code[i] = byte(i) | ||
| } | ||
| cs := namedCS(noncePair(addr, 7), storagePair(addr, slotN(1), padLeft32(0xaa)), codePair(addr, code)) | ||
| cs.Changeset.Pairs = append(cs.Changeset.Pairs, &proto.KVPair{ | ||
| Key: keys.BuildEVMKey(keys.EVMKeyBalance, addr[:]), | ||
| Value: padLeft32(0x05), | ||
| }) | ||
| require.NoError(b, s.CommitStateChanges(1, []*proto.NamedChangeSet{cs})) | ||
| v := s.OpenView() | ||
| b.Cleanup(v.Close) | ||
| return v, gigaAddr(addr) | ||
| } | ||
|
|
||
| func BenchmarkStateViewGetStorage(b *testing.B) { | ||
| v, addr := benchView(b) | ||
| slot := gigatypes.Hash(slotN(1)) | ||
| require.Equal(b, gigatypes.Hash(padLeft32(0xaa)), v.GetStorage(addr, slot)) | ||
| b.ReportAllocs() | ||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| v.GetStorage(addr, slot) | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkStateViewGetBalance(b *testing.B) { | ||
| v, addr := benchView(b) | ||
| require.Equal(b, gigatypes.Hash(padLeft32(0x05)), v.GetBalance(addr)) | ||
| b.ReportAllocs() | ||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| v.GetBalance(addr) | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkStateViewGetCode(b *testing.B) { | ||
| v, addr := benchView(b) | ||
| require.Len(b, v.GetCode(addr), 8*1024) | ||
| b.ReportAllocs() | ||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| v.GetCode(addr) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package vtype | ||
|
|
||
| import ( | ||
| "encoding/binary" | ||
| "errors" | ||
| "fmt" | ||
| ) | ||
|
|
||
| // AccountRow is a read-only view over a serialized account row, in either its compact or full form. | ||
| // It aliases the bytes it was parsed from rather than copying them. | ||
| type AccountRow struct { | ||
| data []byte | ||
| } | ||
|
|
||
| // ParseAccountRow validates data as an account row and returns a view over it. | ||
| func ParseAccountRow(data []byte) (AccountRow, error) { | ||
|
There was a problem hiding this comment. [suggestion] |
||
| if len(data) == 0 { | ||
| return AccountRow{}, errors.New("data is empty") | ||
| } | ||
| if version := AccountDataVersion(data[accountVersionStart]); version != AccountDataVersion0 { | ||
| return AccountRow{}, fmt.Errorf("unsupported serialization version: %d", version) | ||
| } | ||
| if len(data) != accountDataLength && len(data) != accountCompactLength { | ||
| return AccountRow{}, fmt.Errorf("data length should be %d or %d, got %d", | ||
| accountCompactLength, accountDataLength, len(data)) | ||
| } | ||
| return AccountRow{data: data}, nil | ||
| } | ||
|
|
||
| // Balance returns the account's balance. | ||
| func (r AccountRow) Balance() Balance { | ||
| return Balance(r.data[accountBalanceStart:accountNonceStart]) | ||
| } | ||
|
|
||
| // Nonce returns the account's nonce. | ||
| func (r AccountRow) Nonce() uint64 { | ||
| return binary.BigEndian.Uint64(r.data[accountNonceStart:accountCodeHashStart]) | ||
| } | ||
|
|
||
| // CodeHash returns the account's code hash, or the zero hash for a compact row. | ||
| func (r AccountRow) CodeHash() CodeHash { | ||
| if len(r.data) < accountDataLength { | ||
| return CodeHash{} | ||
| } | ||
| return CodeHash(r.data[accountCodeHashStart:accountDataLength]) | ||
| } | ||
|
|
||
| // IsDelete reports whether the row is a tombstone: every field other than the version and block | ||
| // height is zero. | ||
| func (r AccountRow) IsDelete() bool { | ||
| for _, b := range r.data[accountBalanceStart:] { | ||
| if b != 0 { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| // StorageRow is a read-only view over a serialized storage row. It aliases the bytes it was parsed | ||
| // from rather than copying them. | ||
| type StorageRow struct { | ||
| data []byte | ||
| } | ||
|
|
||
| // ParseStorageRow validates data as a storage row and returns a view over it. | ||
| func ParseStorageRow(data []byte) (StorageRow, error) { | ||
| if len(data) == 0 { | ||
| return StorageRow{}, errors.New("data is empty") | ||
| } | ||
| if version := StorageDataVersion(data[storageVersionStart]); version != StorageDataVersion0 { | ||
| return StorageRow{}, fmt.Errorf("unsupported serialization version: %d", version) | ||
| } | ||
| if len(data) != storageDataLength { | ||
| return StorageRow{}, fmt.Errorf("data length should be %d, got %d", storageDataLength, len(data)) | ||
| } | ||
| return StorageRow{data: data}, nil | ||
| } | ||
|
|
||
| // Value returns the storage slot value. | ||
| func (r StorageRow) Value() [StorageValueLength]byte { | ||
| return [StorageValueLength]byte(r.data[storageValueStart:storageDataLength]) | ||
| } | ||
|
|
||
| // IsDelete reports whether the row is a tombstone: the value is all zeros. | ||
| func (r StorageRow) IsDelete() bool { | ||
| for _, b := range r.data[storageValueStart:] { | ||
| if b != 0 { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
AppendEVMPhysicalKeyduplicatesEVMPhysicalKey's codehash/balance canonicalization, prefix-byte lookup, and layout.EVMPhysicalKeycan become a one-liner over it —return AppendEVMPhysicalKey(make([]byte, 0, len(keys.EVMStoreKey)+2+len(strippedKey)), kind, strippedKey)— which keeps its single allocation and itsnil-on-unknown-kind return, and leaves one place where the physical key layout is defined. Right now a change to the layout has to be made twice, and the two can diverge silently since nothing asserts they agree.