Repository navigation
Commit b2c3f50
authored
Remove the tokenfactory governance route (#4431)
The gov router registers a `tokenfactory` route whose handler,
`tokenfactory.NewProposalHandler`, rejects every proposal with
"unrecognized tokenfactory proposal content type". Tokenfactory
registers no `govtypes.Content` implementations and no content type
anywhere in the tree returns `tokenfactory` from `ProposalRoute()`, so
no proposal can ever be submitted to or executed through this route. It
is dead wiring left over from the upstream module.
This drops the `AddRoute(tokenfactorytypes.RouterKey, ...)` call in
`app.New` and deletes `x/tokenfactory/handler.go`. Tokenfactory
messages, keeper and state are untouched.
The gov router is not state. Gov only consults it in `SubmitProposal`
(`HasRoute`) and when executing a passed proposal (`GetRoute`, which
panics on a missing route), and both depend on the proposal's content
type, which cannot point at `tokenfactory`. So this is not app-hash
breaking and needs no upgrade handler. Validated with `go vet`,
golangci-lint and `go test` on `app` and `x/tokenfactory`.1 parent a16e685 commit b2c3f50
2 files changed
Lines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
773 | 773 | | |
774 | 774 | | |
775 | 775 | | |
776 | | - | |
777 | 776 | | |
778 | 777 | | |
779 | 778 | | |
| |||
This file was deleted.
0 commit comments