Repository navigation
Commit 1ea5670
authored
Widen WAL concurrent-close test waits for loaded runners (#4360)
TestConcurrentCloseWithInFlightAsyncWrites starts eight writers against
an async WAL, then gives the first batch one second to show up in
LastOffset before it calls Close. It checks that the writers and Close
finish within three seconds each. In the Coverage job, which runs the
whole repository's tests in one go test invocation, the main loop did
not persist its first batch within that second. The test failed on
"expected some writes before Close()" before it had exercised the close
race it exists to cover. I could not reproduce this locally: 960 runs
with 24 concurrent workers and GOMAXPROCS=1 all passed.
All three waits now allow ten seconds. They exist to confirm that writes
are flowing and to catch a deadlock in Write or Close. A longer bound
still catches a real deadlock, and it no longer mistakes a slow runner
for one. When the machine is healthy the test finishes as quickly as
before, because each wait returns as soon as its condition is met.
Flaked in:
https://github.com/sei-protocol/sei-chain/actions/runs/33406933387/job/995367130421 parent 398513d commit 1ea5670
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
| 556 | + | |
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
| |||
572 | 572 | | |
573 | 573 | | |
574 | 574 | | |
575 | | - | |
| 575 | + | |
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
| |||
582 | 582 | | |
583 | 583 | | |
584 | 584 | | |
585 | | - | |
| 585 | + | |
586 | 586 | | |
587 | 587 | | |
588 | 588 | | |
| |||
0 commit comments