Repository navigation
Commit 398513d
authored
Join scanner goroutines in TestScanRightDeleteRandom (#4354)
TestScanRightDeleteRandom panics with "Fail in goroutine after
TestScanRightDeleteRandom has completed". Its scanner goroutines are
never joined. After `close(stop)` the test clears the list and returns,
while scanners can still be blocked in `WaitFront(t.Context())`. When
the test context is cancelled, `WaitFront` returns an error and the
scanner calls `require.NoError` on a finished test.
The scanners now run in an errgroup and return `WaitFront` errors
instead of calling `require` off the test goroutine. After `close(stop)`
the test waits on the group before clearing the list, then asserts its
error on the test goroutine.
Flaked in:
https://github.com/sei-protocol/sei-chain/actions/runs/34233688470/job/1020858755561 parent b7ab9ac commit 398513d
1 file changed
Lines changed: 12 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
192 | 193 | | |
193 | 194 | | |
194 | 195 | | |
| 196 | + | |
195 | 197 | | |
196 | | - | |
| 198 | + | |
| 199 | + | |
197 | 200 | | |
198 | 201 | | |
199 | 202 | | |
| |||
207 | 210 | | |
208 | 211 | | |
209 | 212 | | |
210 | | - | |
211 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
212 | 217 | | |
213 | 218 | | |
214 | 219 | | |
215 | 220 | | |
216 | 221 | | |
217 | 222 | | |
218 | | - | |
| 223 | + | |
| 224 | + | |
219 | 225 | | |
220 | 226 | | |
221 | 227 | | |
| |||
238 | 244 | | |
239 | 245 | | |
240 | 246 | | |
241 | | - | |
| 247 | + | |
242 | 248 | | |
| 249 | + | |
243 | 250 | | |
244 | 251 | | |
245 | 252 | | |
| |||
0 commit comments