Update expected leaks - #52
Open
L-Jubarah-upb wants to merge 73 commits into
Open
L-Jubarah-upb wants to merge 73 commits into
L-Jubarah-upb wants to merge 73 commits into
Conversation
Removed expected info flows from JSON file.
Updated documentation to reflect changes in data flow and leak status.
Updated the number of leaks in the documentation and adjusted log statements to prevent leaks.
Removed expected info flows related to SMS and device ID.
Added new source and sink information for data flow.
Updated the number of leaks in the documentation and added a comment indicating the log statement as a sink.
Updated the number of leaks in the documentation from 1 to 2.
MarcMil
reviewed
Sep 14, 2026
| }, | ||
| { | ||
| "Source": "android.app.Activity: android.view.View findViewById(int)", | ||
| "Source": "de.ecspride.PrivateDataLeak2: android.view.View findViewById(int)", |
Collaborator
There was a problem hiding this comment.
I'd keep android.app.Activity: android.view.View findViewById(int), even though the bytecode uses PrivateDataLeak2. Since this is a virtual call, referencing android.app.Activity isn't wrong.
| Intent in = new Intent("com.example.deviceid_orderedintent"); | ||
| in.putExtra("data", s); | ||
| sendOrderedBroadcast(in, null); //sink | ||
| sendOrderedBroadcast(in, null); |
Collaborator
There was a problem hiding this comment.
@number_of_leaks should be 0 in this file then
| }, | ||
| { | ||
| "Source": "android.app.Activity: android.content.Intent getIntent()", | ||
| "Method": "org.cert.echoer.MainActivity: void getDataFromIntent()", |
Collaborator
There was a problem hiding this comment.
Can you update the Java code there as well? The //sink comment and the expected flow count should be updated.
| if (resultCode == 0 && requestCode == 0 && data != null) { | ||
| if (data.hasExtra("secret")) { | ||
| if(data.getExtras().getString("secret") != null){ //sink | ||
| if(data.getExtras().getString("secret") != null){ //source |
| { | ||
| if (requestCode == 1) | ||
| { | ||
| Bundle b = data.getExtras(); // source |
Collaborator
There was a problem hiding this comment.
This should not be a source anymore.
| @Override | ||
| public void onClick(View arg0) { | ||
| cFuncDoTheMagic(getApplicationContext()); | ||
| cFuncDoTheMagic(getApplicationContext()); // source, sink |
Collaborator
There was a problem hiding this comment.
IMHO: The expressiveness of our specification does not allow to specify the source/sinks here accurately.
@StevenArzt Your opinion?
|
|
||
| try { | ||
| String string = "dIeciveDteg"; | ||
| String string = "dIeciveDteg"; // source |
Collaborator
There was a problem hiding this comment.
No, the source is:
id = (String) method.invoke(telephonyManager);
| "Line": 30 | ||
| "Source": "android.telephony.TelephonyManager: java.lang.String getDeviceId()", | ||
| "Method": "com.example.onlytelephony.MainActivity: void onCreate(android.os.Bundle)", | ||
| "Line": 54 |
Collaborator
There was a problem hiding this comment.
Line 63 (the one with the reflective method invoke)
| .getSystemService(Context.TELEPHONY_SERVICE); | ||
| method = c.getMethod(string, new Class<?>[0]); | ||
|
|
||
| id = (String) method.invoke(telephonyManager); |
| method = c.getMethod(reverse, new Class<?>[0]); | ||
| Toast.makeText(this, "tele manager is executed", Toast.LENGTH_SHORT) | ||
| .show(); | ||
| id = (String) method.invoke(telephonyManager); |
Collaborator
|
Thanks for you contribution! I've added a few comments on things that should be improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.