#6071 Fix WT_SKIRT not being rendered - #6111
Merged
Merged
Conversation
marchcat
approved these changes
Aug 10, 2026
maxim-productengine
approved these changes
Aug 10, 2026
akleshchev
force-pushed
the
andreyk/viewer_6071_7
branch
from
August 11, 2026 11:22
b11b8ee to
dafa2fb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix system skirt (WT_SKIRT) not rendering and address a related crash when editing shirt while a skirt is present by making mesh rebuild state handling more consistent and centralized.
Changes:
- Centralizes “post-mesh-update” state resets (dirty mesh / skin needed / rebuild flag) into
LLVOAvatar::updateMeshData(). - Updates morph preview pre-render to proactively call
updateMeshData()when geometry is marked for rebuild or meshes are dirty, to avoid inconsistent mid-draw mesh state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/newview/llvoavatar.cpp | Moves dirty-mesh/skin/rebuild-flag resets into updateMeshData() after mesh rebuilds. |
| indra/newview/lltoolmorph.cpp | Forces a mesh data update during param-hint preRender when geometry is flagged dirty/rebuild. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_6071_7
branch
from
August 11, 2026 11:34
dafa2fb to
caf0fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should also fix the crash for editing shirt, when skirt is present