fix(unit_tests): point config tests at internal_test_data on this branch - #15705
Merged
Merged
Conversation
Every test in unit_tests/integration/test_config_get_version_based_on_conf.py
fails before reaching a single assertion:
FileNotFoundError: Couldn't find config file:
/home/ubuntu/scylla-cluster-tests/unit_tests/test_configs/minimal_test_case.yaml
That directory does not exist here. Master moved internal_test_data/ into
unit_tests/test_configs/ in c16e41a ("improvement(treewide): Move
internal_test_data into unit_tests"), which was never backported, so on this
branch the fixtures still live in internal_test_data/. The test file arrived
via cherry-pick carrying master's path.
The two files are byte-identical, so only the path is wrong.
Also corrected the same stale path in test_utils__operator__multitenant_common.py
(latent: setup_default_env sets it, but _multitenant_class_with_shared_options
overwrites SCT_CONFIG_FILES before anything loads it, so nothing failed) and in
the AGENTS.md layout description.
Left unit_tests/test_config_get_version_based_on_conf.py alone on purpose — it
is the stale pre-rename duplicate that scylladb#15691 removes, and editing it here
would create a modify/delete conflict.
pehala
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while triaging the 40 integration failures on #15691 — this accounts for 30 of them, and is entirely independent of that PR.
Problem
Every test in
unit_tests/integration/test_config_get_version_based_on_conf.pyfails before reaching a single assertion:unit_tests/test_configs/does not exist on this branch. Master moved the fixtures withc16e41a55c"improvement(treewide): Move internal_test_data into unit_tests", which was never backported here — the yamls still live ininternal_test_data/. The test file arrived by cherry-pick carrying master's path, so it could never have passed on this branch.The two files are byte-identical (
diffofbranch-2025.1:internal_test_data/minimal_test_case.yamlagainstmaster:unit_tests/test_configs/minimal_test_case.yamlis empty), so the path is the only thing wrong.Verification
Run inside the branch's own hydra image,
scylladb/hydra:v1.91-2025.1-pytest-xdist:Couldn't find config fileoccurrencesThe config now loads and the tests proceed into real validation. I am deliberately not claiming this turns 30 tests green: the remaining failures are live-lookup rot of the same class master fixed in #15670/#15671 —
Azure Image for scylla_version='master:latest' not found in eastus,GCE image for scylla_version='2026.2' was not found,KeyError: 'docker-image-name'— plus, in my local run only, 15 failures from absent AWS credentials that CI does have. What this PR fixes is the blanket blocker that stopped every one of them from even getting that far.Also in this change
unit_tests/test_utils__operator__multitenant_common.pycarried the same stale path. It is latent:setup_default_envsets it, but_multitenant_class_with_shared_optionsoverwritesSCT_CONFIG_FILESbefore anything loads it. Confirmed neutral — that file gives an identical 4 failed / same reasons (Unable to locate credentials, local-only) with and without the change.AGENTS.mdlayout description updated to nameinternal_test_data/instead of master'sunit_tests/test_configs/.Deliberately untouched
unit_tests/test_config_get_version_based_on_conf.py— the stale pre-rename duplicate that #15691 deletes. Fixing the path there too would create a modify/delete conflict between the two PRs.