[Backport perf-v17] fix(integration-tests): stop pinning artifact URLs that get garbage collected - #15682
Conversation
|
@fruch - This PR has conflicts, therefore it was moved to |
67d1175 to
8ded0ca
Compare
|
Resolved the cherry-pick conflicts and dropped one commit on purpose — please don't restore it. Dropped: On master that commit edits
Backporting the test would mean backporting the external-decode feature too, which is well outside the scope of "stop pinning artifact URLs". So it is dropped, and the branch no longer adds Kept — both verified against this branch's code and layout:
Checks run locally on the pushed tree: Pre-existing failures on this branch, unrelated to this backport — please don't read them as regressions:
|
Integration test results (build #2) — this PR's fix is confirmed working by CI
Direct evidence the fix works, by diffing this run against #15680's run on the same branch and same integration suite (the two differ only by this PR's change):
That is the test this backport targets, and it flipped green. It is no longer in the failure list at all. The remaining failures are all pre-existing on Two of those have verified causes worth recording:
Consequence for reviewers: the |
8ded0ca to
5ab8496
Compare
…024.1 `get_specific_tag_of_docker_image` looked up scylla-enterprise-nightly tags under the `enterprise` rolling branch. That branch stopped producing builds when enterprise development folded into the unified releases, and its relocatables are gone -- the 00-Build.txt fetch now 404s, so the function raises for every caller (and for `test_get_specific_tag_of_docker_image[scylladb/scylla-enterprise-nightly]`). `enterprise-2024.1` is the only branch still publishing scylla-enterprise-nightly images (last build June 2026), so point the lookup there. (cherry picked from commit c481dd1)
`test_unified_package` pinned a master relocatable from November 2023. Unlike the sibling tests, which only run config validation, this one calls `get_version_based_on_conf()`, which downloads and unpacks the package to read SCYLLA-VERSION-FILE. Unstable relocatables are garbage collected within a few months, so the pinned URL 404s and the test fails with "Unified package not found or failed to download". Resolve the current master package with the existing `latest_unified_package()` helper and derive the expected version from the returned filename, so there is nothing left to rot. (cherry picked from commit 0716d88)
5ab8496 to
1793d71
Compare
Fixes the three remaining integration test failures from PR-15647 build 1 (unrelated to that PR — a renovate gemini bump). All three are pinned artifact URLs that have since been garbage collected or retired upstream. Companion to #15670, which covers the Secrets Manager failures.
What was failing
test_config_get_version_based_on_conf::test_unified_packageFileNotFoundError: Unified package not found or failed to download: .../2023-11-13T03:04:27Z/scylla-unified-5.5.0~dev-...tar.gztest_external_backtrace_service::test_decode_via_external_service_returns_symbols404 ... for url: https://backtrace.scylladb.com/api/backtracetest_version_utils::test_get_specific_tag_of_docker_image[scylladb/scylla-enterprise-nightly]404 ... /unstable/scylla-enterprise/enterprise/relocatable/latest/00-Build.txtFixes
Unified package. The test pinned a master relocatable from November 2023. Unlike its sibling tests, which only run config validation, this one calls
get_version_based_on_conf(), which downloads and unpacks the package to readSCYLLA-VERSION-FILE— so the URL has to actually exist, and unstable relocatables are collected within months. Now resolved through the existinglatest_unified_package()helper, with the expected version derived from the returned filename.Backtrace service. The pinned build id (
527bc254…, 2026.1.0~dev) is still indexed, but the unstripped package it needs is gone, so the API answers:Now resolved from
unstable/scylla/master/relocatable/latest/00-Build.txt. Newer builds exist in S3 but the service does not index them until they are promoted (checked: today's 14:11 and 16:36 builds returnCould not find any build with BuildID, whilelatest/resolves and symbolizes), solatest/is the freshest reliably-known id. If it happens not to be indexed yet the test skips rather than reporting a failure that says nothing about SCT.Enterprise nightly.
get_specific_tag_of_docker_imageresolvedscylladb/scylla-enterprise-nightlyunder theenterpriserolling branch. That branch is gone from downloads.scylladb.com —unstable/scylla-enterprise/now holds onlyenterprise-2024.1/, which is still building (last build June 2026) and still publishes exactly those images:So the lookup points there. This is a production fix, not just a test fix —
sct_configcalls this function to resolvescylla_docker_imagefor enterprise versions and it was raising for every caller.Testing
Parent PR: #15671