Skip to content

dialer/replayer: preserve records when CQL stream IDs are reused #991

Description

@dkropachev

Problem

loadFramesFromFile stores records in map[int]dialer.Record keyed only by stream ID. CQL stream IDs are reusable, so every later request or response on an ID overwrites the earlier record. loadResponseFramesFromFiles consequently loses earlier request/response pairs and may later panic on a missing request hash or replay the wrong response.

The driver clears stream IDs after responses. With the default bucket-rotating allocator, sequential traffic can return to an earlier ID after roughly 512 requests, and appended recordings from reconnects can repeat IDs even sooner.

Reproduction

Create Reads and Writes files containing two ordered request/response pairs, both using stream 7. loadResponseFramesFromFiles returns one pair instead of two.

Suggested fix

Preserve an ordered queue of records per stream ID and pair requests with responses in per-stream order. Add coverage for multiple uses of one stream ID, including requests with different hashes.

Discovered while reviewing PR #590; this limitation predates that PR and is deferred so the metadata-ID work can merge independently.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions